Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print statement with CodegenLogger.log #2346

Closed
hiltonc opened this issue Jun 28, 2022 · 1 comment · Fixed by #2348
Closed

Replace print statement with CodegenLogger.log #2346

hiltonc opened this issue Jun 28, 2022 · 1 comment · Fixed by #2348

Comments

@hiltonc
Copy link
Contributor

hiltonc commented Jun 28, 2022

Bug report

I'm using ApolloCodegenLib to script codegen, and want to reduce the verbosity of the output. I found that I could do CodegenLogger.level = .error, but I still see this output:

SHASUM of downloaded file: 479e1c12adf631c43c093fdd9dd8e5c8eed33cb15e39de7165ce6f5e7f759904

I've traced it to

print("SHASUM of downloaded file: \(shasum)")
, I think it just needs to be changed to use CodegenLogger.log instead of print.

Versions

Please fill in the versions you're currently using:

  • apollo-ios SDK version: 0.39.0 (but I see this on the tip of main as well)
  • Xcode version: 14.0.0 beta 2
  • Swift version: 5.6
  • Package manager: SPM

Steps to reproduce

Script ApolloCodegenLib, set CodegenLogger.level = .error, download a schema. "SHASUM of downloaded file..." continues to print.

@calvincestari
Copy link
Member

Yes, this seems reasonable. Would you be able to submit a PR making the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants