Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node LTS Version Out of Date #671

Closed
giladronat opened this issue Jul 25, 2019 · 3 comments · Fixed by #672
Closed

Node LTS Version Out of Date #671

giladronat opened this issue Jul 25, 2019 · 3 comments · Fixed by #672
Labels
build-issue Issues occurring when attempting to build
Milestone

Comments

@giladronat
Copy link
Contributor

Currently, the CLI script installs the exact Node version specified using nvm (#434) and switches to it, then installs Apollo locally (which is not ideal in my opinion #401). That Node version should be LTS but appears to be out of date (currently 8.15.0, LTS is at 10.16.0). I'm not sure if simply updating REQUIRED_NODE_VERSION is the best solution hence the issue instead of a PR.

REQUIRED_NODE_VERSION=8.15.0

@designatednerd
Copy link
Contributor

@giladronat OMG hi!

Yeah - it'd be nice to have that be a minimum rather than an exact version. You're welcome to tackle that in a PR if you want, otherwise I'll try to deal with that when I'm less melted next week.

@designatednerd designatednerd added the build-issue Issues occurring when attempting to build label Jul 25, 2019
@giladronat
Copy link
Contributor Author

@designatednerd Hi hi! It's so cool to see you working on the framework; you're doing a fantastic job thus far.

I don't know that I fully understand the reason an exact version was instated in the first place. Would making it a minimum version break anything for anyone?

If you think changing it to a minimum version requirement is the way to go and that doesn't interfere with anything you were planning I'll work on it! 😃

@designatednerd
Copy link
Contributor

Reading that PR, the reasoning is somewhat similar to what I've had to do in terms of pinning our dependencies: Making sure everyone is running the same version of Node so that when something breaks, we've got a cleaner path to debugging.

Maybe let's start by updating to the current LTS version, and I'll add a note to your earlier thing about looking at whether we should go back to specifying just the major version of node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-issue Issues occurring when attempting to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants