From a22a83a3af53b0f7baa4f93d0ce5cbf7256e1a98 Mon Sep 17 00:00:00 2001 From: Maya Koneval Date: Wed, 4 Oct 2023 15:14:01 -0700 Subject: [PATCH] update documentation kinda --- docs/source/api/plugin/landing-pages.mdx | 4 ++-- packages/server/src/plugin/landingPage/default/index.ts | 2 +- packages/server/src/plugin/landingPage/default/types.ts | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/source/api/plugin/landing-pages.mdx b/docs/source/api/plugin/landing-pages.mdx index bd73aaafb1f..30945bb10ed 100644 --- a/docs/source/api/plugin/landing-pages.mdx +++ b/docs/source/api/plugin/landing-pages.mdx @@ -85,7 +85,7 @@ This landing page is designed for use in local development, where `NODE_ENV` is By default, this plugin uses the latest version of the landing page published to Apollo's CDN. If you'd like to pin the current version, you can specify it here. -The current latest version is available at [this link](https://apollo-server-landing-page.cdn.apollographql.com/_latest/version.txt). +The current latest version is available at [this link](https://apollo-server-landing-page.cdn.apollographql.com/latest/version.txt). @@ -363,7 +363,7 @@ This landing page is designed for use in production. It provides a copyable comm By default, this plugin uses the latest version of the landing page published to Apollo's CDN. If you'd like to pin the current version, you can specify it here. -The current latest version is available at [this link](https://apollo-server-landing-page.cdn.apollographql.com/_latest/version.txt). +The current latest version is available at [this link](https://apollo-server-landing-page.cdn.apollographql.com/latest/version.txt). diff --git a/packages/server/src/plugin/landingPage/default/index.ts b/packages/server/src/plugin/landingPage/default/index.ts index 4e19f117870..9c0313faffb 100644 --- a/packages/server/src/plugin/landingPage/default/index.ts +++ b/packages/server/src/plugin/landingPage/default/index.ts @@ -88,7 +88,7 @@ function ApolloServerPluginLandingPageDefault( ): ImplicitlyInstallablePlugin { const explorerVersion = maybeVersion ?? 'v3'; const sandboxVersion = maybeVersion ?? 'v2'; - const apolloServerLandingPageVersion = maybeVersion ?? '_latest'; + const apolloServerLandingPageVersion = maybeVersion ?? '_latest'; // note _latest is frozen is time as of this PR https://github.com/apollographql/embeddable-explorer/pull/280 const apolloServerVersion = `@apollo/server@${packageVersion}`; const scriptSafeList = [ diff --git a/packages/server/src/plugin/landingPage/default/types.ts b/packages/server/src/plugin/landingPage/default/types.ts index 3ea9c02c97d..885c6b2f24f 100644 --- a/packages/server/src/plugin/landingPage/default/types.ts +++ b/packages/server/src/plugin/landingPage/default/types.ts @@ -38,10 +38,10 @@ type InitialStateForEmbeds = export type ApolloServerPluginLandingPageDefaultBaseOptions = { /** - * By default, the landing page plugin uses the latest version of the landing - * page published to Apollo's CDN. If you'd like to pin the current version, - * pass the SHA served at - * https://apollo-server-landing-page.cdn.apollographql.com/_latest/version.txt + * By default, the landing page plugin uses the version of the landing + * page published to Apollo's CDN from https://github.com/apollographql/embeddable-explorer/commit/73baf89f5308d263425bbafe21a842a26123cfac. + * If you'd like to pin the current version, pass the SHA served at + * https://apollo-server-landing-page.cdn.apollographql.com/latest/version.txt * here. */ version?: string;