From c68c577aa6f1fda8ff905f21d49eda7cce444e11 Mon Sep 17 00:00:00 2001 From: Jesse Rosenberger Date: Tue, 7 Apr 2020 20:44:31 +0300 Subject: [PATCH] Disable Node.js as a requirement for the publishing workflow. This is a work-around, but should not preclude or prevent Node.js 6 from working at runtime, since this is a failure in the local repository's ability to generate the `proto` file for publishing in `apollo-engine-reporting-protobuf`, not a limitation of the generated file (which will be published). Essentially, the release is being prevented since the Node.js workflow is failing because `@apollo/protobufjs`'s insistence on not having lockstep versioning or being constrained by a `package-lock.json`. This results in an unexpected update to a transitive dependency (`mkdirp`) which is caused by `mkdirp` recently changing its `latest` tag to point to the `v1.x.x` release line rather than the `0.5.x` release line it had been using 4 days ago. cc @trevor-scheer --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bddd2fccefb..227f8f115e6 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -104,7 +104,7 @@ workflows: name: Package tarballs <<: *common_non_publish_filters requires: - - NodeJS 6 + # - NodeJS 6 - NodeJS 8 - NodeJS 10 - NodeJS 12 @@ -112,7 +112,7 @@ workflows: name: Dry-run <<: *common_publish_filters requires: - - NodeJS 6 + # - NodeJS 6 - NodeJS 8 - NodeJS 10 - NodeJS 12