Show cookie toggle for embedded landing pages #7358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 794215b:
|
trevor-scheer
approved these changes
Feb 15, 2023
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
Feb 15, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server@4.4.0 ### Minor Changes - [#7358](#7358) [`f2d433b4f`](f2d433b) Thanks [@esilverm](https://github.com/esilverm)! - Show "Include Cookies" toggle in Embedded Sandbox landing page. ## @apollo/server-integration-testsuite@4.4.0 ### Patch Changes - Updated dependencies \[[`f2d433b4f`](f2d433b)]: - @apollo/server@4.4.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mayakoneval
reviewed
Mar 8, 2023
Comment on lines
44
to
46
|
|
||
| includeCookies?: boolean; // defaults to 'false' | ||
| hideCookieToggle?: boolean; // defaults to 'true' | ||
| } |
There was a problem hiding this comment.
@esilverm @trevor-scheer we don't support hideCookieToggle for the embedded Explorer, only Sandbox.
This section of code should be reverted iiuc. I am adding it to this PR #7431
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Related embed PR
This code relies on several other PRs to be approved/merged, so I will keep it as a draft until it is ready.
Context
Users are getting confused because the embedded sandbox doesn't show the
includeCookiestoggle. This toggle should be visible for AS4 users when they are in embedded sandbox.What Changed
This adjusts the way the getEmbeddedHTML helpers use the landing page config options. These options should stay the same and the user shouldn't experience any changes to how they need to configure their Apollo Server configuration.
Instead, we use the
includeCookiesvalue as an initial value for the cookie toggle in explorer, pass it toinitialState, and turn off ahideCookieToggleflag to expose this value to users in explorer.How to test
Use codesandbox link below