Make apollo-router compile on docs.rs build servers #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollographql/federation-rs#185 was not sufficient since each package being published to crates.io needs to have its own `[package.metadata.docs.rs]` config.
bnjjj
approved these changes
Sep 20, 2022
A new test checks that it is up to date.
|
I tried this on docs.rs which uncovered another issue: https://docs.rs/crate/lets-see-if-this-builds-on-docs-rs/0.0.1/builds/633305 The new commit attempts to fix that, with https://docs.rs/crate/lets-see-if-this-builds-on-docs-rs/0.0.2 currently in the build queue. |
SimonSapin
changed the title
bnjjj
approved these changes
Sep 20, 2022
abernix
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apollographql/federation-rs#185 was not sufficient since each package being published to crates.io needs to have its own
[package.metadata.docs.rs]config.