This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AP-1023 Use rollup to bundle library #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/AP-1023/rollup
branch
from
bc0fae9 to
6d9c49e
Compare
timbotnik
reviewed
Dec 19, 2019
rollup.config.js
Outdated
| function CJS() { | ||
| return { | ||
| input: [ | ||
| "src/Button", |
There was a problem hiding this comment.
It seems strange that we'd need to modify our build config every time we add something to src - can we just grab everything in there?
There was a problem hiding this comment.
You're right. I made this change. It makes the config a little more confusing, but will be future-proof. Thanks!
There was a problem hiding this comment.
Answering your question more directly, we can't grab everything. We have to exclude certain things, but that's fine! We can exclude scripts/ directories, stories, and test files easily.
justinanastos
added
minor
justinanastos
force-pushed
the
justin/AP-1023/rollup
branch
from
6d9c49e to
0c2459b
Compare
justinanastos
force-pushed
the
justin/AP-1023/rollup
branch
from
0c2459b to
41c8331
Compare
|
I'm going to merge this in. We can roll back if necessary! |
|
🚀 PR was released in v2.22.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to AP-1023
Why
We're going to use a 3rd party tooltip library to manage our tooltips and popovers. All 3rd party tooltip libraries require some CSS be included in the final bundle. Our current bundle process does not allow this because we use
tsc.The solution I've chosen is to use Rollup. Rollup is intended to bundle packages together for consumption. This only builds a CJS build right now, but we can expand this to build a es module package that can be tree shaken automatically later.
Rollup does not support bundling css out of the box; we'll have to use a plugin for that (coming with the associated PR!).
Testing
This is tested by tryin git in AGM. We should find a way to run our test suite against our compiled output files so we can guarantee that everything works. See https://github.com/mdg-private/engine-frontend/pull/1995