This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-1850 FTD-35 Upgrade Icon docspage and storybook stories
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
requested review from
cheapsteak,
trevorblades,
jglovier,
timbotnik,
AlexanderMann,
Jephuff,
daniman and
jgzuke
justinanastos
added
the
documentation
justinanastos
force-pushed
the
justin/icon-story-exploration
branch
2 times, most recently
from
7241572 to
551c540
Compare
|
I'm a huge fan of this. It's going to make Chromatic reviews much more friendly. Thanks for implementing this one!! |
jgzuke
reviewed
Sep 12, 2020
@jgzuke We do pay by the snapshot. We get 35k included in our current plan and we used 11.3k last month. When we go over it'll cost $0.005/snapshot, costing $0.75 per CI build for the icons. I think that's worth the easier reviews and better format here. |
justinanastos
force-pushed
the
justin/icon-story-exploration
branch
from
551c540 to
2afc0d6
Compare
Closed
justinanastos
changed the title
Icon docspage and storybook stories
justinanastos
changed the title
Icon docspage and storybook storiesIcon docspage and storybook stories
justinanastos
changed the title
Icon docspage and storybook storiesIcon docspage and storybook stories
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FTD-35 and AR-1850
My goal here was to make the chromatic diffs more useful because whenever we change anything, it's incredibly hard to see what actually changed. This will give us individual stories for each icon and will show them nicely in a docs page.
📦 Published PR as canary version:
7.14.2-canary.235.5208.0✨ Test out this PR locally via:
npm install @apollo/space-kit@7.14.2-canary.235.5208.0 # or yarn add @apollo/space-kit@7.14.2-canary.235.5208.0