Sk rename ez crypto gem #1
Conversation
1 similar comment
There was a problem hiding this comment.
looks pretty good. Couple of things:
- make sure to add a .ruby-version
- you do no longer need to appreiase ruby 2.3.3; you can remove it from Rakefile and Appraisals
- we usually have a gemfiles directory which stores the gemfiles generated by appraisal for the different versions under test
- you should add a cii build
Rakefile
Outdated
| end | ||
|
|
||
| namespace :test do | ||
| AfGems::RubyAppraisalTask.new(:all, [ 'ruby-2.3.3', 'ruby-2.5.3']) |
There was a problem hiding this comment.
it would be nice if that could appraise 2.5.3 and 2.6.3, you might need to change the Appraisal file as well
Appraisals
Outdated
| @@ -1,5 +1,5 @@ | |||
| case(RUBY_VERSION) | |||
| when '2.3.3', '2.5.3' then | |||
| when '2.3.3', '2.5.3', '2.6.3' then | |||
There was a problem hiding this comment.
you can drop 2.3.3 here and in the Rakefile
ezcrypto.gemspec
Outdated
| s.version = '0.7.2' | ||
| s.date = '2009-03-10' | ||
| s.version = EzCrypto::VERSION | ||
| s.date = '2019-05-31' |
There was a problem hiding this comment.
is this usually hardcoded in our other gems?
There was a problem hiding this comment.
I could not get gem bump to work without a version.rb file.
af_crypto, af_encrypted_attr, af_email all have version.rb.
There was a problem hiding this comment.
yep. That is a requirement for AfGem pretty much. I was talking about the date though :-)
There was a problem hiding this comment.
Oh. I removed the date, it's pointless
skapfer
force-pushed
the
skRenameEzCryptoGem
branch
2 times, most recently
from
c84f3ac to
1f18792
Compare
skapfer
force-pushed
the
skRenameEzCryptoGem
branch
from
1f18792 to
3953a13
Compare
No description provided.