#134 FIX #141
Merged
#134 FIX #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change List: - #134 FIX. The DeviceTime property was added and it works with Appium node 1.5 - improvements of locking methods. The LockDevice(seconds) is obsolete and it is going to be removed in the next release. Since Appium node server v1.5.x it is recommended to use AndroidDriver.Lock()()...AndroidDriver.Unlock() or IOSDriver.Lock(int seconds) instead.
|
This looks reasonable to me, without any knowledge of the language. |
| @@ -898,6 +901,19 @@ public void Zoom(IWebElement el) | |||
|
|
|||
| #endregion | |||
|
|
|||
| #region Device Time | |||
|
|
|||
There was a problem hiding this comment.
add doc tags here.. would be good for people using this class to know what this property is used for.
|
looks silky otherwise. i like how you put the obsolete tag on there :) |
TikhomirovSergey
added a commit
that referenced
this pull request
Feb 20, 2016
Ok. Good. I'm merging...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List:
134 FIX. The DeviceTime property was added and it works with Appium
node 1.5
improvements of locking methods. The LockDevice(seconds) is obsolete
and it is going to be removed in the next release. Since Appium node
server v1.5.x it is recommended to use
AndroidDriver.Lock()()...AndroidDriver.Unlock() or IOSDriver.Lock(int
seconds) instead.