Fix temporary directory creation to avoid failing pkl-core tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzensp
requested changes
Oct 14, 2024
There was a problem hiding this comment.
CI is failing with
/root/project/Sources/PklSwift/Utils.swift:90:106: error: incorrect argument label in call (have 'filePath:', expected 'string:')
(try FileManager.default.url(for: .itemReplacementDirectory, in: .userDomainMask, appropriateFor: URL(filePath: "/")!, create: true)).absoluteString
^~~~~~~~~
string
Other than that; LGTM
Sources/PklSwift/Utils.swift
Outdated
Comment on lines
89
to
90
| public func tempDir() throws -> String { | ||
| (try FileManager.default.url(for: .itemReplacementDirectory, in: .userDomainMask, appropriateFor: URL(filePath: "/")!, create: true)).absoluteString |
There was a problem hiding this comment.
I'd be inclined to let tempDir() return a URL, considering all the uses, but it's non-blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, pkl-swift's tests (and pkl-gen-swift) write to the root of the user's temporary directory. This causes problems for some tests in pkl-core that rely on not finding a PklProject in any parent directory.