From 4a5f80781022695353df2c23d0fd945fa1e527a9 Mon Sep 17 00:00:00 2001
From: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
Date: Fri, 13 Dec 2024 15:41:39 -0800
Subject: [PATCH] loadbalancer-experimental: remove/hide unused public API

Motivation:

Reduce public API that is not currently used.

Modifications:

- Make `LoadBalancingPolicy.name()` visibility pkg-private;
- Remove `RequestTracker.ErrorClass.isLocal()`;
---
 .../loadbalancer/LoadBalancingPolicy.java      |  2 +-
 .../loadbalancer/P2CLoadBalancingPolicy.java   |  2 +-
 .../loadbalancer/RequestTracker.java           | 18 ++++--------------
 .../RoundRobinLoadBalancingPolicy.java         |  2 +-
 .../loadbalancer/DefaultLoadBalancerTest.java  |  2 +-
 5 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicy.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicy.java
index 600e9aaa57..3e7bad80d9 100644
--- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicy.java
+++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancingPolicy.java
@@ -39,7 +39,7 @@ public abstract class LoadBalancingPolicy<ResolvedAddress, C extends LoadBalance
      * The name of the load balancing policy.
      * @return the name of the load balancing policy
      */
-    public abstract String name();
+    abstract String name();
 
     @Override
     public abstract String toString();
diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/P2CLoadBalancingPolicy.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/P2CLoadBalancingPolicy.java
index e8662e77c1..0c620c3a9b 100644
--- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/P2CLoadBalancingPolicy.java
+++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/P2CLoadBalancingPolicy.java
@@ -61,7 +61,7 @@ HostSelector<ResolvedAddress, C> buildSelector(final List<Host<ResolvedAddress,
     }
 
     @Override
-    public String name() {
+    String name() {
         return "P2C";
     }
 
diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
index b9ccee09b0..95964b3c22 100644
--- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
+++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RequestTracker.java
@@ -67,31 +67,21 @@ enum ErrorClass {
         /**
          * Failures caused locally, these would be things that failed due to an exception locally.
          */
-        LOCAL_ORIGIN_REQUEST_FAILED(true),
+        LOCAL_ORIGIN_REQUEST_FAILED,
 
         /**
          * Failures related to locally enforced timeouts waiting for responses from the peer.
          */
-        EXT_ORIGIN_TIMEOUT(false),
+        EXT_ORIGIN_TIMEOUT,
 
         /**
          * Failures returned from the remote peer. This will be things like 5xx responses.
          */
-        EXT_ORIGIN_REQUEST_FAILED(false),
+        EXT_ORIGIN_REQUEST_FAILED,
 
         /**
          * Failure due to cancellation.
          */
-        CANCELLED(true);
-
-        private final boolean isLocal;
-
-        ErrorClass(boolean isLocal) {
-            this.isLocal = isLocal;
-        }
-
-        public boolean isLocal() {
-            return isLocal;
-        }
+        CANCELLED
     }
 }
diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancingPolicy.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancingPolicy.java
index f299145d96..0c3db4c2c0 100644
--- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancingPolicy.java
+++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/RoundRobinLoadBalancingPolicy.java
@@ -47,7 +47,7 @@ HostSelector<ResolvedAddress, C> buildSelector(final List<Host<ResolvedAddress,
     }
 
     @Override
-    public String name() {
+    String name() {
         return "RoundRobin";
     }
 
diff --git a/servicetalk-loadbalancer-experimental/src/test/java/io/servicetalk/loadbalancer/DefaultLoadBalancerTest.java b/servicetalk-loadbalancer-experimental/src/test/java/io/servicetalk/loadbalancer/DefaultLoadBalancerTest.java
index a6db67a68a..e7d479a99f 100644
--- a/servicetalk-loadbalancer-experimental/src/test/java/io/servicetalk/loadbalancer/DefaultLoadBalancerTest.java
+++ b/servicetalk-loadbalancer-experimental/src/test/java/io/servicetalk/loadbalancer/DefaultLoadBalancerTest.java
@@ -442,7 +442,7 @@ private static class TestLoadBalancerPolicy extends LoadBalancingPolicy<String,
         int rebuilds;
 
         @Override
-        public String name() {
+        String name() {
             return "TestPolicy";
         }