Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repeat's endless printing #437

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Fix Repeat's endless printing #437

merged 2 commits into from
Apr 2, 2022

Conversation

KeithBird
Copy link
Contributor

To prevent newbies from being scared off by endless printing in the terminal, I changed the default value of Repeat.count from .max to 2.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@KeithBird
Copy link
Contributor Author

Recommit #432

@rauhul rauhul requested a review from natecook1000 April 1, 2022 05:40
@rauhul
Copy link
Contributor

rauhul commented Apr 1, 2022

@swift-ci please test

@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit 18b0039 into apple:main Apr 2, 2022
@KeithBird
Copy link
Contributor Author

🎉

@KeithBird KeithBird deleted the repeat-endless-printing branch April 3, 2022 01:49
leuski pushed a commit to leuski/swift-argument-parser that referenced this pull request Jun 17, 2022
* 'main' of github.com:apple/swift-argument-parser: (114 commits)
  Fix `AsyncParseableCommand` hierarchy (apple#436)
  Add experimental manual page generation (apple#332)
  Improving edit distance string extension (apple#446)
  List valid options in error messages for enum array argument (apple#445)
  Remove LinuxMain.swift (apple#367)
  Hide hidden subcommands from completions (apple#443)
  Update changelog for 1.1.2 release (apple#441)
  Fix error message for @option array without values (apple#435)
  Fix Repeat's endless printing (apple#437)
  build: statically link ArgumentParserToolInfo always (apple#424)
  Update changelog for the 1.1.1 release (apple#428)
  build: complete the changes from apple#423 (apple#425)
  Remove platform requirement from Package.swift (apple#427)
  build: repair the build after apple#404 (apple#423)
  Fix broken links/incorrect variance calculation (apple#422)
  Update changelog for the 1.1.0 release (apple#421)
  Update documentation (apple#420)
  Make `@OptionGroup(visibility:)` a public API (apple#419)
  Support an `async` entry point for commands (apple#404)
  Fix a typo and template links (apple#418)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants