decide if we want to support Swift 4.0 for HTTP2

[weissi]

Current situation

• Swift 4.0 is not supported for swift-nio-http2 (neither 0.1.0 nor master compiles)
• Package.swift claims Swift 4.0 support (via // swift-tools-version:4.0)

Possible fixes:

• officially don't support Swift 4.0
• fix 4.0 compilation.

paging @normanmaurer , @AlanQuatermain , @Lukasa , @ianpartridge, @pushkarnk, @tanner0101, @0xTim

[ianpartridge]

It depends on what it would take to support 4.0. If it's easy, then why not support it?

If it's difficult or involves some compromises, then it's probably better not to support it.

[normanmaurer]

👍

…

Am 30.08.2018 um 17:41 schrieb Ian Partridge ***@***.***>: It depends on what it would take to support 4.0. If it's easy, then why not support it? If it's difficult or involves some compromises, then it's probably better not to support it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[AlanQuatermain]

I’d be quite happy for the project to require latest-minor-release of its target Swift version. Given the larger nature of the changes in Swift 4.2 I’m prepared to accept 4.1 as the baseline, but I’d *prefer* to go with 4.2 as soon as it’s officially available.

…

Sent from my iPhone

On Aug 30, 2018, at 9:22 AM, Norman Maurer ***@***.***> wrote: 👍 > Am 30.08.2018 um 17:41 schrieb Ian Partridge ***@***.***>: > > It depends on what it would take to support 4.0. If it's easy, then why not support it? > > If it's difficult or involves some compromises, then it's probably better not to support it. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[tanner0101]

officially don't support Swift 4.0

This option is fine by me. Vapor 3 requires >= 4.1. Vapor 4 will likely require >= 5.

[MrMage]

I would definitely be in favor of requiring Swift 4.1 or even 4.2.

[weissi]

thanks everybody, Swift 4.0 is a pain so I proposed a PR to make it officially 4.1 only. We can't go 4.2-only just yet because 4.2 isn't released yet and also Vapor/Kitura require running on 4.1.

[weissi]

(but letting @Lukasa approve the PR in case he has information that I don't)