Skip to content

Use APIs available on older macOS in tests #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Use APIs available on older macOS in tests #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...nAPIURLSessionTests/URLSessionBidirectionalStreamingTests/HTTPBodyOutputStreamTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@ class HTTPBodyOutputStreamBridgeTests: XCTestCase {
XCTAssertNil(inputStream.streamError)

// Check the output stream closes gracefully in response to the input stream closing.
HTTPBodyOutputStreamBridge.streamQueue.asyncAndWait {
XCTAssertEqual(requestStream.outputStream.streamStatus, .closed)
XCTAssertNil(requestStream.outputStream.streamError)
}
HTTPBodyOutputStreamBridge.streamQueue.asyncAndWait(
execute: DispatchWorkItem {
XCTAssertEqual(requestStream.outputStream.streamStatus, .closed)
XCTAssertNil(requestStream.outputStream.streamError)
}
)
}

func testHTTPBodyOutputStreamBridgeBackpressure() async throws {
Expand Down
4 changes: 2 additions & 2 deletions ...onTests/URLSessionBidirectionalStreamingTests/URLSessionBidirectionalStreamingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ class URLSessionBidirectionalStreamingTests: XCTestCase {
// Just count the bytes received and verify the total matches what the server sent.
case count
// Add some artificial delay to simulate business logic to show how the backpressure mechanism works (or not).
case delay(Duration)
case delay(TimeAmount)
}

func testStreamingDownload(
Expand Down Expand Up @@ -387,7 +387,7 @@ class URLSessionBidirectionalStreamingTests: XCTestCase {
for try await receivedResponseChunk in responseBody! {
print("Client received some response body bytes (numBytes: \(receivedResponseChunk.count))")
print("Client doing fake work for \(delay)s")
try await Task.sleep(for: delay)
try await Task.sleep(nanoseconds: UInt64(delay.nanoseconds))
}
}

Expand Down