This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add python codecov #2976
Merged
Merged
add python codecov #2976
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f549be8
bump up pytest and others
guihao-liang c931180
set range for hypothesis
guihao-liang aa9384e
skip doc
guihao-liang 40da38b
use pytest-cov plugin instead
guihao-liang a929146
ignore files in codecov report
guihao-liang 41cd32d
Merge branch 'master' into 01-30-codecov
guihao-liang 09f9fe9
generate code
guihao-liang ae0df4b
absolute path
guihao-liang afdbde7
Merge branch 'master' into 01-30-codecov
guihao-liang c52d104
improve code
guihao-liang 9cf81de
Merge branch '01-30-codecov' of https://github.com/Jarvi-Izana/turicr…
guihao-liang 404921c
remove redundant echo
guihao-liang 9524fe3
prepare for merge
guihao-liang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# https://coverage.readthedocs.io/en/latest/config.html | ||
|
||
[run] | ||
source = src/python/turicreate/ | ||
branch = True | ||
parallel = True | ||
|
||
[report] | ||
# Regexes for lines to exclude from consideration | ||
exclude_lines = | ||
# Have to re-enable the standard pragma | ||
pragma: no cover | ||
|
||
# Don't complain about missing debug-only code: | ||
def __repr__ | ||
if self\.debug | ||
|
||
# Don't complain if tests don't hit defensive assertion code: | ||
raise AssertionError | ||
raise NotImplementedError | ||
|
||
# Don't complain if non-runnable code isn't run: | ||
if 0: | ||
if False: | ||
if __name__ == .__main__.: | ||
|
||
ignore_errors = True | ||
|
||
omit = | ||
*/__init__.py | ||
src/python/turicreate/_cython/* | ||
src/python/turicreate/test/* | ||
src/python/turicreate/_deps/*_mock.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,9 +18,9 @@ WORKSPACE=${SCRIPT_DIR}/.. | |
|
||
unset PYTHONPATH | ||
|
||
cd $WORKSPACE | ||
cd "$WORKSPACE" | ||
scripts/install_python_toolchain.sh | ||
source scripts/python_env.sh $BUILD_TYPE | ||
source scripts/python_env.sh "$BUILD_TYPE" | ||
|
||
# Make python unit tests print unity server log on exception | ||
export TURI_VERBOSE=1 | ||
|
@@ -34,7 +34,7 @@ pop_ld_library_path() { | |
export LD_LIBRARY_PATH=$OLD_LIBRARY_PATH | ||
} | ||
push_ld_library_path | ||
cd $TURI_BUILD_ROOT/src/python | ||
cd "$TURI_BUILD_ROOT"/src/python | ||
make -j4 | ||
pop_ld_library_path | ||
|
||
|
@@ -44,15 +44,16 @@ if ! type "parallel" 2> /dev/null; then | |
if [[ $OSTYPE != msys ]]; then | ||
cmd=${PYTHON_EXECUTABLE} | ||
fi | ||
cmd="${cmd} ${PYTEST_EXECUTABLE} -v $PYTHONPATH/turicreate/test --junit-xml=alltests.pytest.xml" | ||
echo $cmd | ||
cmd="${cmd} ${PYTEST_EXECUTABLE} --cov -v $PYTHONPATH/turicreate/test \ | ||
--junit-xml=alltests.pytest.xml" | ||
echo "$cmd" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You probably want to remove this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's right! will do. |
||
$cmd | ||
else | ||
cmd="" | ||
if [[ $OSTYPE != msys ]]; then | ||
cmd=${PYTHON_EXECUTABLE} | ||
fi | ||
cmd="${cmd} ${PYTEST_EXECUTABLE} -v -s --junit-xml={}.pytest.xml {}" | ||
cmd="${cmd} ${PYTEST_EXECUTABLE} --cov -v -s --junit-xml={}.pytest.xml {}" | ||
echo "Tests are running in parallel. Output is buffered until job is done..." | ||
find turicreate/test -name "*.py" | parallel --group -P 4 $cmd | ||
find turicreate/test -name "*.py" | parallel --group -P 4 "$cmd" | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
"$WORKSPACE"
the same as${WORKSPACE}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the quotes are intentional. https://github.com/koalaman/shellcheck/wiki/SC2086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you use this tool called
shellcheck
along withpre-commit
.