Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting for nodeAffinity and pod(Anti)Affinity #116

Merged
merged 3 commits into from
May 19, 2020
Merged

Add setting for nodeAffinity and pod(Anti)Affinity #116

merged 3 commits into from
May 19, 2020

Conversation

arturdzm
Copy link
Contributor

@arturdzm arturdzm commented May 19, 2020 •
edited
Loading

What this PR does / why we need it?:

  • Adds affinity settings such as nodeAffinity, podAffinity and podAntiAffinity
  • Fixes fields that are not copied to ServiceMonitor

@arturdzm arturdzm requested a review from navidsh May 19, 2020 14:37
@navidsh navidsh requested a review from leochr May 19, 2020 15:05
leochr
leochr approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@arturdzm arturdzm merged commit 077ed70 into master May 19, 2020
@edavidj edavidj mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leochr leochr leochr approved these changes

@navidsh navidsh Awaiting requested review from navidsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturdzm @leochr