Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys should be trimmed to prevent user error #16

Closed
Nooba opened this issue Nov 18, 2019 · 0 comments · Fixed by #30
Closed

Keys should be trimmed to prevent user error #16

Nooba opened this issue Nov 18, 2019 · 0 comments · Fixed by #30
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Nooba
Copy link
Contributor

Nooba commented Nov 18, 2019

It may happen that the user had an accidental space or newline in a key, which, while it might be allowed on some platforms, make overall very little sense to me.
I believe adding a trimming action to it would be good, or at the very least a warning log.
@jvigne jvigne added enhancement New feature or request good first issue Good for newcomers labels Dec 2, 2019
@felginep felginep mentioned this issue Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/bugfix felginep/ad_localize
2 participants
@Nooba @jvigne