Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Knative private #122

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Knative private #122

merged 3 commits into from
Sep 26, 2019

Conversation

navidsh
Copy link
Member

@navidsh navidsh commented Sep 25, 2019 •
edited
Loading

What this PR does / why we need it:

  • Updates the Knative operator to make Knative route accessible locally if expose field is not set to true. This is to be consistent with the expose field for non-Knative deployments
  • Updates user guide with info about exposing Knative route
  • Sets labels to the resources created through Knative service
  • Adds unit tests for checking Knative service's visibility label depending on the expose field

@navidsh navidsh self-assigned this Sep 25, 2019
@navidsh
Copy link
Member Author

navidsh commented Sep 25, 2019

Fixes #120

@arturdzm arturdzm merged commit 8606419 into master Sep 26, 2019
@navidsh navidsh deleted the knative-private branch September 28, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arturdzm arturdzm arturdzm approved these changes

Assignees

@navidsh navidsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidsh @arturdzm