Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Appsody Operator must-gather #209

Merged
merged 7 commits into from
Jan 17, 2020
Merged

Appsody Operator must-gather #209

merged 7 commits into from
Jan 17, 2020

Conversation

JusteenR
Copy link
Contributor

What this PR does / why we need it?:

  • Appsody Operator must-gather is a tool built on top of OpenShift must-gather that expands its capabilities to gather information about the Appsody Operator.
  • Creates a local directory with a dump of relevant troubleshooting information
  • Includes information about the pods that are not in the ready state, appsody operator pod(s), knative, appsody application, and the resources that are managed by the operator

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #148

@JusteenR JusteenR requested a review from navidsh January 16, 2020 18:53
@JusteenR JusteenR changed the title Justeen Appsody Operator must-gather Jan 16, 2020
Copy link
Member

@navidsh navidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JusteenR. Just a few comments

stage: build must gather
script:
- make build-must-gather
- name: Build must gather image and push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this stage is doing both build and push, do we still need Build must gather image stage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially following the the operator build step but it isn't necessary for this so I removed the Build must gather image stage.

CHANGELOG.md Outdated
@@ -10,6 +10,10 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Added

- Added must-gather scripts for troubleshooting. ([#148](https://github.com/appsody/appsody-operator/issues/148))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to PR(s). Please update the link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seems like there is a conflict with the master branch in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the link and fixed the conflicts.

```

Note: `must-gather` flag is a new feature added to oc v4.x. If you are using an older version of oc, you can get a new version of the CLI from here. You can use oc v4.x against 3.11 cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "OpenShift client CLI" instead of "oc".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in "...CLI from here..." is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed oc to OpenShift client CLI and added the link.

@@ -0,0 +1 @@
# Appsody Operator must-gather
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add text to refer people to the troubleshooting doc

Copy link
Member

@navidsh navidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JusteenR

@navidsh navidsh merged commit e93acb0 into master Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add must gather scripts for Appsody
2 participants