This repository has been archived by the owner on Mar 29, 2020. It is now read-only.
remove default value and type hinting for magic methods #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing some tests, and in creating a mock of this class I came across this error:
ErrorException: Declaration of Mockery_1_Appstract_LushHttp_Lush::__call($method, array $args) should be compatible with Appstract\LushHttp\Lush::__call($method, array $arguments = Array)
Looking at the signature of the
__call
methods, I noticed that default values had been entered.Since this methods are always handled by php itself, and
$arguments
will always be an array, even if no arguments were passed to the called methods, to avoid mocking problems I've removed defaults and tipe hinting declarations.