-
Target (至少选择一个)
+
+ {intl.formatMessage({ id: 'web.iceworksProjectCreator.RaxScaffoldTypeForm.targetTitle' })}
+
{targets.map((item) => {
const selected = selectedTargets.some((selectedTarget) => selectedTarget === item.type);
@@ -119,7 +125,9 @@ const RaxScaffoldTypeForm: React.FC = ({ value, onChange }) =
{selectedTargets.some((item) => item === 'web') && (
<>
- 为 Web 应用选择应用类型
+
+ {intl.formatMessage({ id: 'web.iceworksProjectCreator.RaxScaffoldTypeForm.webAppTitle' })}
+
{webAppTypes.map((item) => (
= ({ value, onChange }) =
)}
{selectedTargets.some((item) => item === 'miniapp' || item === 'wechat-miniprogram' || item === 'kraken') && (
<>
-
为小程序选择构建类型
+
+ {intl.formatMessage({ id: 'web.iceworksProjectCreator.RaxScaffoldTypeForm.miniAppTitle' })}
+
{miniAppTypes.map((item) => (
{
const intl = useIntl();
const [selectedSource, setSelectedSource] = useState({});
@@ -98,7 +102,7 @@ const ScaffoldMarket = ({ onScaffoldSelect, curProjectField, children, onOpenCon
iconName = projectType;
}
return (
-
@@ -136,8 +140,8 @@ const ScaffoldMarket = ({ onScaffoldSelect, curProjectField, children, onOpenCon
: jsScaffoldsList.includes(item.source.npm)
? 'js'
: '';
- const isRax = selectedSource.type === 'rax';
- const CardComponent = isRax ? MobileScaffoldCard : ScaffoldCard;
+ const isWireless = checkIsWireless(selectedSource);
+ const CardComponent = isWireless ? MobileScaffoldCard : Card;
return (
{
- let clones: IClone[] = [];
- let repetitionPercentage = 0;
+ // let clones: IClone[] = [];
+ // let repetitionPercentage = 0;
- try {
- clones = await jscpd([
- '--formats-exts',
- supportExts.join(','),
- directory,
- '--ignore',
- `"${ignoreDirs.map((ignoreDir) => `${path.join(directory, '/')}**/${ignoreDir}/**`).join(',')}"`,
- '--reporters',
- 'json',
- '--output',
- tempDir,
- '--silent',
- ]);
+ // try {
+ // clones = await jscpd([
+ // '--formats-exts',
+ // supportExts.join(','),
+ // directory,
+ // '--ignore',
+ // `"${ignoreDirs.map((ignoreDir) => `${path.join(directory, '/')}**/${ignoreDir}/**`).join(',')}"`,
+ // '--reporters',
+ // 'json',
+ // '--output',
+ // tempDir,
+ // '--silent',
+ // ]);
- const repeatabilityResultFile = path.join(tempDir, 'jscpd-report.json');
- if (fs.existsSync(repeatabilityResultFile)) {
- const repeatabilityResult = fs.readJSONSync(repeatabilityResultFile);
- repetitionPercentage = repeatabilityResult.statistics.total.percentage;
- }
- } catch (e) {
- // ignore
- console.log(e);
- }
+ // const repeatabilityResultFile = path.join(tempDir, 'jscpd-report.json');
+ // if (fs.existsSync(repeatabilityResultFile)) {
+ // const repeatabilityResult = fs.readJSONSync(repeatabilityResultFile);
+ // repetitionPercentage = repeatabilityResult.statistics.total.percentage;
+ // }
+ // } catch (e) {
+ // // ignore
+ // console.log(e);
+ // }
return {
- score: new Scorer().minus(repetitionPercentage),
- clones,
+ score: 0,
+ clones: [],
};
}
diff --git a/packages/eslint-plugin-security-practices/README.md b/packages/eslint-plugin-security-practices/README.md
new file mode 100644
index 000000000..e22419fcf
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/README.md
@@ -0,0 +1,57 @@
+# @iceworks/eslint-plugin-security-practices
+
+Iceworks doctor security practices eslint plugin.
+
+## Installation
+
+Install [esLint](http://eslint.org), `@ice/spec` and `@iceworks/eslint-plugin-security-practices`:
+
+```shell
+$ npm install --save-dev eslint @ice/spec @iceworks/eslint-plugin-security-practices
+```
+
+## Usage
+
+Add `security-practices` to the plugins section of your `.eslintrc` configuration file.
+
+```json
+{
+ "plugins": [
+ "@iceworks/security-practices"
+ ]
+}
+```
+
+Then configure the rules you want to use under the rules section.
+
+```json
+{
+ "plugins": [
+ "@iceworks/security-practices"
+ ],
+ "rules": {
+ "@iceworks/security-practices/rule-name": 2
+ }
+}
+```
+
+Or you can only use extends to set default rules config.
+
+```json
+{
+ "extends": ["plugin:@iceworks/security-practices/recommended"]
+};
+```
+
+## Supported Rules
+
+* [`no-http-url`](./docs/rules/no-http-url.md) Recommended the http url switch to HTTPS.
+* [`no-internal-url`](./docs/rules/no-internal-url.md) The group internal url is not recommended.
+* [`no-patent-licenses`](./docs/rules/no-patent-licenses.md) Recommend to use the dependency with Open-Source license.
+* [`no-secret-info`](./docs/rules/no-secret-info.md) Don't show `password` `token` and `secret` in plain text.
+* [`no-sensitive-word`](./docs/rules/no-sensitive-word.md) Don't use some sensitive word.
+
+
+
+
+
diff --git a/packages/eslint-plugin-security-practices/docs/rules/no-http-url.md b/packages/eslint-plugin-security-practices/docs/rules/no-http-url.md
new file mode 100644
index 000000000..c04a238d6
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/docs/rules/no-http-url.md
@@ -0,0 +1,16 @@
+# no-http-url
+
+Recommended the http url switch to HTTPS.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+var test = 'http://test.com';
+var jsx = 
;
+```
+
+## When Not To Use It
+
+If your website only support http.
diff --git a/packages/eslint-plugin-security-practices/docs/rules/no-internal-url.md b/packages/eslint-plugin-security-practices/docs/rules/no-internal-url.md
new file mode 100644
index 000000000..f5d95c642
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/docs/rules/no-internal-url.md
@@ -0,0 +1,24 @@
+# Internal url is not recommended (no-internal-url)
+
+The group internal url is not recommended.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+request('yourSite.com');
+
+```
+
+### Options
+
+Group internal url list。
+
+```json
+{
+ "rules": {
+ "@iceworks/security-practices/no-internal-url": ["warn", ["yourSite.com"]]
+ },
+}
+```
diff --git a/packages/eslint-plugin-security-practices/docs/rules/no-patent-licenses.md b/packages/eslint-plugin-security-practices/docs/rules/no-patent-licenses.md
new file mode 100644
index 000000000..988c23fb1
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/docs/rules/no-patent-licenses.md
@@ -0,0 +1,9 @@
+# no-patent-licenses
+
+ Recommend to use the dependency with Open-Source license.
+
+## Rule Details
+
+See [https://spdx.org/licenses/](https://spdx.org/licenses/).
+
+The package with Patent(like 'BSD-2-Clause-Patent') will be warned.
diff --git a/packages/eslint-plugin-security-practices/docs/rules/no-secret-info.md b/packages/eslint-plugin-security-practices/docs/rules/no-secret-info.md
new file mode 100644
index 000000000..837c696cd
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/docs/rules/no-secret-info.md
@@ -0,0 +1,31 @@
+# no-secret-info
+
+Don't show `password` `token` and `secret` in plain text.
+
+
+## Rule Details
+
+It is very dangerous to use plain text with key contains `password` `token` and `secret`.
+
+Examples of **incorrect** code for this rule:
+
+```js
+
+var accessKeySecret = 'xxxx';
+
+var client ={
+ accessKeyToken: 'xxxx'
+};
+```
+
+Examples of **correct** code for this rule:
+
+```js
+
+var accessKeySecret = process.env.ACCESS_KEY_SECRET;
+
+var client ={
+ accessKeyToken: process.env.ACCESS_KEY_SECRET
+};
+
+```
diff --git a/packages/eslint-plugin-security-practices/docs/rules/no-sensitive-word.md b/packages/eslint-plugin-security-practices/docs/rules/no-sensitive-word.md
new file mode 100644
index 000000000..271635cc5
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/docs/rules/no-sensitive-word.md
@@ -0,0 +1,26 @@
+# no-sensitive-word
+
+Don't use some sensitive word.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+
+// stupid xxx
+const jsx = ",
+ output: "
",
+ parserOptions: {
+ ecmaFeatures: {
+ jsx: true
+ }
+ },
+ errors: [{
+ message: "Recommended 'http://test.com' switch to HTTPS"
+ }]
+ }]
+});
diff --git a/packages/eslint-plugin-security-practices/tests/lib/rules/no-internal-url.js b/packages/eslint-plugin-security-practices/tests/lib/rules/no-internal-url.js
new file mode 100644
index 000000000..bdfb8e7a5
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/tests/lib/rules/no-internal-url.js
@@ -0,0 +1,27 @@
+"use strict";
+
+var rule = require("../../../lib/rules/no-internal-url");
+var RuleTester = require("eslint").RuleTester;
+
+var ruleTester = new RuleTester();
+
+ruleTester.run("no-internal-url", rule, {
+
+ valid: [{
+ code: "var test = 'https://test.com';"
+ }],
+
+ invalid: [{
+ code: "var test = 'https://test.com';",
+ options: [['test.com']],
+ errors: [{
+ message: "The url 'https://test.com' is not recommended"
+ }]
+ },
+ {
+ code: "var test = 'https://test.alibaba-inc.com';",
+ errors: [{
+ message: "The url 'https://test.alibaba-inc.com' is not recommended"
+ }]
+ }]
+});
diff --git a/packages/eslint-plugin-security-practices/tests/lib/rules/no-secret-info.js b/packages/eslint-plugin-security-practices/tests/lib/rules/no-secret-info.js
new file mode 100644
index 000000000..553122a9f
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/tests/lib/rules/no-secret-info.js
@@ -0,0 +1,34 @@
+"use strict";
+
+var rule = require("../../../lib/rules/no-secret-info");
+var RuleTester = require("eslint").RuleTester;
+
+var ruleTester = new RuleTester();
+
+ruleTester.run("no-secret-info", rule, {
+ valid: [{
+ code: "var accessKeySecret = process.env.ACCESS_KEY_SECRET;"
+ },{
+ code: `
+ var client ={
+ accessKeyToken: process.env.ACCESS_KEY_SECRET
+ };
+ `
+ }],
+
+ invalid: [{
+ code: "var accessKeySecret = 'xxxx';",
+ errors: [{
+ message: "Detect that the 'xxxx' might be a secret token, Please check!"
+ }]
+ }, {
+ code: `
+ var client ={
+ accessKeyToken: 'xxxx'
+ };
+ `,
+ errors: [{
+ message: "Detect that the 'xxxx' might be a secret token, Please check!"
+ }]
+ }]
+});
diff --git a/packages/eslint-plugin-security-practices/tests/lib/rules/no-sensitive-word.js b/packages/eslint-plugin-security-practices/tests/lib/rules/no-sensitive-word.js
new file mode 100644
index 000000000..edbdad680
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/tests/lib/rules/no-sensitive-word.js
@@ -0,0 +1,21 @@
+"use strict";
+
+var rule = require("../../../lib/rules/no-sensitive-word");
+var RuleTester = require("eslint").RuleTester;
+
+var ruleTester = new RuleTester();
+
+ruleTester.run("no-sensitive-word", rule, {
+
+ valid: [{
+ code: "// nice"
+ }],
+
+ invalid: [{
+ code: "// fuck",
+ options: [['fuck']],
+ errors: [{
+ message: "Detect the sensitive word: 'fuck'"
+ }]
+ }]
+});
diff --git a/packages/eslint-plugin-security-practices/tsconfig.json b/packages/eslint-plugin-security-practices/tsconfig.json
new file mode 100644
index 000000000..f2414a4b5
--- /dev/null
+++ b/packages/eslint-plugin-security-practices/tsconfig.json
@@ -0,0 +1,9 @@
+{
+ "extends": "../../tsconfig.settings.json",
+ "compilerOptions": {
+ "baseUrl": "./",
+ "rootDir": "src",
+ "outDir": "lib"
+ },
+ "exclude": ["tests", "lib"]
+}
diff --git a/packages/material-service/package.json b/packages/material-service/package.json
index 2685b12bf..d2d7def81 100644
--- a/packages/material-service/package.json
+++ b/packages/material-service/package.json
@@ -1,6 +1,6 @@
{
"name": "@iceworks/material-service",
- "version": "0.1.9",
+ "version": "0.1.10",
"description": "Iceworks material service for VSCode extension.",
"files": [
"lib"
diff --git a/packages/material-service/src/index.ts b/packages/material-service/src/index.ts
index e72637f39..be176e3a8 100644
--- a/packages/material-service/src/index.ts
+++ b/packages/material-service/src/index.ts
@@ -11,9 +11,14 @@ import { getProjectType } from '@iceworks/project-service';
import i18n from './i18n';
const ICE_MATERIAL_SOURCE = 'https://ice.alicdn.com/assets/materials/react-materials.json';
+const VUE_MATERIAL_SOURCE = 'https://ice.alicdn.com/assets/materials/vue-materials.json';
+const MINI_PROGRAM_MATERIAL_SOURCE = 'https://ice.alicdn.com/assets/materials/miniprogram-materials.json';
+const RAX_MATERIAL_SOURCE = 'https://ice.alicdn.com/assets/materials/rax-materials.json';
+
const MATERIAL_BASE_HOME_URL = 'https://ice.work/component';
const MATERIAL_BASE_REPOSITORY_URL = 'https://github.com/alibaba-fusion/next/tree/master/src';
const ICE_BASE_COMPONENTS_SOURCE = 'https://ice.alicdn.com/assets/base-components-1.x.json';
+
const OFFICAL_MATERIAL_SOURCES = [
{
name: 'PC Web',
@@ -22,19 +27,30 @@ const OFFICAL_MATERIAL_SOURCES = [
source: ICE_MATERIAL_SOURCE,
description: i18n.format('package.materialService.index.webDescription'),
},
+];
+
+const OFFICAL_MATERIAL_SOURCES_FOR_INTERNAL = [
{
name: i18n.format('package.materialService.index.raxTitle'),
type: 'rax',
client: 'wireless',
- source: 'https://ice.alicdn.com/assets/materials/rax-materials.json',
+ source: RAX_MATERIAL_SOURCE,
description: i18n.format('package.materialService.index.raxDescription'),
},
];
+
const OFFICAL_MATERIAL_SOURCES_FOR_EXTERNAL = [
+ {
+ name: i18n.format('package.materialService.index.miniProgramTitle'),
+ type: 'miniProgram',
+ client: 'wireless',
+ source: MINI_PROGRAM_MATERIAL_SOURCE,
+ description: i18n.format('package.materialService.index.miniProgramDescription'),
+ },
{
name: i18n.format('package.materialService.index.vueTitle'),
type: 'vue',
- source: 'https://ice.alicdn.com/assets/materials/vue-materials.json',
+ source: VUE_MATERIAL_SOURCE,
description: i18n.format('package.materialService.index.vueDescription'),
},
];
@@ -63,9 +79,10 @@ export async function getSources(specifiedType?: string): Promise type === specifiedType) : sources;
diff --git a/packages/material-service/src/locales/en-US.json b/packages/material-service/src/locales/en-US.json
index 82e66bac4..e115005fc 100644
--- a/packages/material-service/src/locales/en-US.json
+++ b/packages/material-service/src/locales/en-US.json
@@ -4,6 +4,8 @@
"package.materialService.index.raxDescription": "Offical Materials Based On Rax Components Rax CLI",
"package.materialService.index.vueTitle": "Vue materials",
"package.materialService.index.vueDescription": "Offical Materials Based On Element And Vue CLI ",
+ "package.materialService.index.miniProgramTitle": "Mini Program",
+ "package.materialService.index.miniProgramDescription": "This is an ice material project for Mini Program App",
"package.materialService.index.materialSourceExistError": "Material source already exists.",
"package.materialService.index.materialNameExistError": "Material name s already exists.",
"package.materialService.index.materialDataError": "Incorrect material source "
diff --git a/packages/material-service/src/locales/zh-CN.json b/packages/material-service/src/locales/zh-CN.json
index 2fc43e8ce..750a10540 100644
--- a/packages/material-service/src/locales/zh-CN.json
+++ b/packages/material-service/src/locales/zh-CN.json
@@ -4,6 +4,8 @@
"package.materialService.index.raxDescription": "基于 Rax 组件和 Rax 脚手架的官方物料",
"package.materialService.index.vueTitle": "Vue 物料源",
"package.materialService.index.vueDescription": "基于 Element, Vue CLI 的 Vue 官方物料",
+ "package.materialService.index.miniProgramTitle": "小程序",
+ "package.materialService.index.miniProgramDescription": "基于 React 的小程序物料源",
"package.materialService.index.materialSourceExistError": "物料源已存在。",
"package.materialService.index.materialNameExistError": "物料源名称已存在。",
"package.materialService.index.materialDataError": "物料源数据错误。"
diff --git a/packages/project-service/package.json b/packages/project-service/package.json
index f990b5ce5..fb6a03be9 100644
--- a/packages/project-service/package.json
+++ b/packages/project-service/package.json
@@ -1,6 +1,6 @@
{
"name": "@iceworks/project-service",
- "version": "0.1.15",
+ "version": "0.1.16",
"description": "Iceworks project service for VSCode extension.",
"files": [
"lib"
diff --git a/packages/project-service/src/index.ts b/packages/project-service/src/index.ts
index d193a3c6d..4f19410eb 100644
--- a/packages/project-service/src/index.ts
+++ b/packages/project-service/src/index.ts
@@ -40,17 +40,22 @@ export async function getProjectLanguageType() {
}
export async function getProjectType() {
- const { dependencies = {} } = await readPackageJSON(projectPath);
- if (dependencies.rax) {
- return 'rax';
+ try {
+ const { dependencies = {} } = await readPackageJSON(projectPath);
+ if (dependencies.rax) {
+ return 'rax';
+ }
+ if (dependencies.react) {
+ return 'react';
+ }
+ if (dependencies.vue) {
+ return 'vue';
+ }
+ return 'unknown';
+ } catch (e) {
+ console.error(e);
+ return 'unknown';
}
- if (dependencies.react) {
- return 'react';
- }
- if (dependencies.vue) {
- return 'vue';
- }
- return 'unknown';
}
export async function getProjectFramework() {
diff --git a/tsconfig.json b/tsconfig.json
index eb7f18e5c..9e82b80db 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -2,6 +2,7 @@
"files": [],
"references": [
{ "path": "packages/doctor" },
+ { "path": "packages/eslint-plugin-security-practices" },
{ "path": "packages/constant" },
{ "path": "packages/i18n" },
{ "path": "packages/ice-npm-utils" },
汇款
; + +``` + +### Options + +Sensitive word list。 + +```json +{ + "rules": { + "@iceworks/security-practices/no-sensitive-word": ["warn", ["fuck", "汇款"]], + }, +} + diff --git a/packages/eslint-plugin-security-practices/package.json b/packages/eslint-plugin-security-practices/package.json new file mode 100644 index 000000000..1bb49a234 --- /dev/null +++ b/packages/eslint-plugin-security-practices/package.json @@ -0,0 +1,34 @@ +{ + "name": "@iceworks/eslint-plugin-security-practices", + "version": "0.1.0", + "description": "Iceworks doctor security practices eslint plugin.", + "files": [ + "docs/", + "lib/" + ], + "keywords": [ + "iceworks", + "doctor", + "security", + "eslint", + "eslintplugin", + "eslint-plugin" + ], + "main": "lib/index.js", + "publishConfig": { + "access": "public" + }, + "scripts": { + "test": "mocha tests --recursive" + }, + "dependencies": { + "@ice/spec": "^1.0.1", + "fastscan": "^1.0.6", + "line-column": "^1.0.2", + "requireindex": "~1.1.0" + }, + "devDependencies": { + "eslint": "^7.1.0", + "mocha": "^7.2.0" + } +} diff --git a/packages/eslint-plugin-security-practices/src/configs/recommended.ts b/packages/eslint-plugin-security-practices/src/configs/recommended.ts new file mode 100644 index 000000000..f7fcacba2 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/configs/recommended.ts @@ -0,0 +1,29 @@ +import { eslint, deepmerge } from '@ice/spec'; + +const defaultEslintConfig = Object.assign({}, eslint); + +if (!defaultEslintConfig.overrides) { + defaultEslintConfig.overrides = []; +} + +// Recommended security practices eslint config +module.exports = deepmerge(defaultEslintConfig, { + plugins: ['@iceworks/security-practices'], + overrides: [ + { + files: ['package.json'], + processor: '@iceworks/security-practices/.json', + rules: { + quotes: 'off', + '@iceworks/security-practices/no-patent-licenses': 'warn', + }, + }, + ], + rules: { + 'react/react-in-jsx-scope': 'off', // For rax + '@iceworks/security-practices/no-http-url': 'warn', + '@iceworks/security-practices/no-internal-url': ['warn', ['taobao.net']], + '@iceworks/security-practices/no-secret-info': 'error', + '@iceworks/security-practices/no-sensitive-word': ['warn', ['fuck']], + }, +}); diff --git a/packages/eslint-plugin-security-practices/src/docsUrl.ts b/packages/eslint-plugin-security-practices/src/docsUrl.ts new file mode 100644 index 000000000..e2ea5aac5 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/docsUrl.ts @@ -0,0 +1,5 @@ +const repoUrl = 'https://github.com/ice-lab/iceworks/tree/master/packages/eslint-plugin-security-practices'; + +export default function docsUrl(ruleName: string) { + return `${repoUrl}/docs/rules/${ruleName}.md`; +} diff --git a/packages/eslint-plugin-security-practices/src/index.ts b/packages/eslint-plugin-security-practices/src/index.ts new file mode 100644 index 000000000..7fd55ed0e --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/index.ts @@ -0,0 +1,13 @@ +import * as requireIndex from 'requireindex'; + +export const rules = requireIndex(`${__dirname}/rules`); +export const configs = requireIndex(`${__dirname}/configs`); + +export const processors = { + '.json': { + preprocess(text: string) { + // As JS file + return [`module.exports = ${text}`]; + }, + }, +}; diff --git a/packages/eslint-plugin-security-practices/src/rules/no-http-url.ts b/packages/eslint-plugin-security-practices/src/rules/no-http-url.ts new file mode 100644 index 000000000..0cd8ecc2e --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/rules/no-http-url.ts @@ -0,0 +1,36 @@ +import docsUrl from '../docsUrl'; + +const RULE_NAME = 'no-http-url'; + +module.exports = { + name: RULE_NAME, + meta: { + type: 'suggestion', + docs: { + url: docsUrl(RULE_NAME), + }, + fixable: 'code', + messages: { + // eslint-disable-next-line + noHttpUrl: "Recommended '{{url}}' switch to HTTPS", + }, + }, + create(context: any) { + return { + Literal: function handleRequires(node: any) { + if (node.value && node.value.indexOf('http:') === 0) { + context.report({ + node, + messageId: 'noHttpUrl', + data: { + url: node.value, + }, + fix: (fixer: any) => { + return fixer.replaceText(node, `'${node.value.replace('http:', 'https:')}'`); + }, + }); + } + }, + }; + }, +}; diff --git a/packages/eslint-plugin-security-practices/src/rules/no-internal-url.ts b/packages/eslint-plugin-security-practices/src/rules/no-internal-url.ts new file mode 100644 index 000000000..86519bb54 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/rules/no-internal-url.ts @@ -0,0 +1,45 @@ +import docsUrl from '../docsUrl'; + +const RULE_NAME = 'no-internal-url'; + +const defaultUrlList = ['alibaba-inc.com']; + +module.exports = { + name: RULE_NAME, + meta: { + type: 'suggestion', + docs: { + url: docsUrl(RULE_NAME), + }, + fixable: null, + schema: [ + { + type: 'array', + items: { + type: 'string', + }, + }, + ], + messages: { + // eslint-disable-next-line + noInternalUrl: "The url '{{url}}' is not recommended", + }, + }, + + create(context) { + const reg = new RegExp(defaultUrlList.concat(context.options[0] || []).join('|')); + return { + Literal: function handleRequires(node: any) { + if (reg.test(node.value)) { + context.report({ + node, + messageId: 'noInternalUrl', + data: { + url: node.value, + }, + }); + } + }, + }; + }, +}; diff --git a/packages/eslint-plugin-security-practices/src/rules/no-patent-licenses.ts b/packages/eslint-plugin-security-practices/src/rules/no-patent-licenses.ts new file mode 100644 index 000000000..6385ecc88 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/rules/no-patent-licenses.ts @@ -0,0 +1,62 @@ +import * as path from 'path'; +import * as fs from 'fs-extra'; +import docsUrl from '../docsUrl'; + +const RULE_NAME = 'no-patent-licenses'; + +module.exports = { + name: RULE_NAME, + meta: { + type: 'suggestion', + docs: { + url: docsUrl(RULE_NAME), + }, + fixable: null, + messages: { + // eslint-disable-next-line + noPatentLicenses: "The package '{{dependencyName}}' with license '{{license}}' may cause some problem.", + }, + }, + + create(context) { + if (path.basename(context.getFilename()) !== 'package.json') { + return; + } + + const cwd = context.getCwd(); + + return { + Property: function handleRequires(node: any) { + if ( + node.key && + node.key.value && + (node.key.value === 'dependencies' || node.key.value === 'devDependencies') && + node.value && + node.value.properties + ) { + node.value.properties.forEach((property) => { + if (property.key && property.key.value) { + const dependencyName = property.key.value; + const dependencyPackageFile = path.join(cwd, 'node_modules', dependencyName, 'package.json'); + if (fs.existsSync(dependencyPackageFile)) { + const dependencyPackage = fs.readJSONSync(dependencyPackageFile); + const license = dependencyPackage.license || ''; + // https://spdx.org/licenses/ + if (license.indexOf('Patent') > -1) { + context.report({ + loc: property.loc, + messageId: 'noPatentLicenses', + data: { + dependencyName, + license, + }, + }); + } + } + } + }); + } + }, + }; + }, +}; diff --git a/packages/eslint-plugin-security-practices/src/rules/no-secret-info.ts b/packages/eslint-plugin-security-practices/src/rules/no-secret-info.ts new file mode 100644 index 000000000..429727a98 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/rules/no-secret-info.ts @@ -0,0 +1,49 @@ +import docsUrl from '../docsUrl'; + +const RULE_NAME = 'no-secret-info'; + +const DANGEROUS_KEYS = ['secret', 'token', 'password']; + +module.exports = { + meta: { + type: 'problem', + docs: { + url: docsUrl(RULE_NAME), + }, + fixable: null, + messages: { + // eslint-disable-next-line + noSecretInfo: "Detect that the '{{secret}}' might be a secret token, Please check!", + }, + }, + + create(context) { + const reg = new RegExp(DANGEROUS_KEYS.join('|')); + + return { + Literal: function handleRequires(node: any) { + if ( + (node.parent && + // var secret = 'test'; + node.parent.type === 'VariableDeclarator' && + node.parent.id && + node.parent.id.name && + reg.test(node.parent.id.name.toLocaleLowerCase())) || + // { secret: 'test' }; + (node.parent.type === 'Property' && + node.parent.key && + node.parent.key.name && + reg.test(node.parent.key.name.toLocaleLowerCase())) + ) { + context.report({ + node, + messageId: 'noSecretInfo', + data: { + secret: node.value, + }, + }); + } + }, + }; + }, +}; diff --git a/packages/eslint-plugin-security-practices/src/rules/no-sensitive-word.ts b/packages/eslint-plugin-security-practices/src/rules/no-sensitive-word.ts new file mode 100644 index 000000000..524477ba5 --- /dev/null +++ b/packages/eslint-plugin-security-practices/src/rules/no-sensitive-word.ts @@ -0,0 +1,64 @@ +import * as FastScanner from 'fastscan'; +import * as lineColumn from 'line-column'; +import docsUrl from '../docsUrl'; + +const RULE_NAME = 'no-sensitive-word'; + +const defaultWordList = ['stupid', 'foolish', 'silly']; + +module.exports = { + name: RULE_NAME, + meta: { + type: 'suggestion', + docs: { + url: docsUrl(RULE_NAME), + }, + fixable: null, + schema: [ + { + type: 'array', + items: { + type: 'string', + }, + }, + ], + messages: { + // eslint-disable-next-line + noSensitiveWord: "Detect the sensitive word: '{{word}}'", + }, + }, + + create(context) { + const sourceCode = context.getSourceCode(); + const sourceCodeText = sourceCode.getText(); + + const wordList = defaultWordList.concat(context.options[0] || []); + const scanner = new FastScanner(wordList); + + scanner.search(sourceCodeText).forEach((wordInfo) => { + const [wordIndex, word] = wordInfo; + const startPositionInfo = lineColumn(sourceCodeText).fromIndex(wordIndex); + const endPositionInfo = lineColumn(sourceCodeText).fromIndex(wordIndex + word.length - 1); + + context.report({ + loc: { + start: { + line: startPositionInfo.line, + column: startPositionInfo.col, + }, + end: { + line: endPositionInfo.line, + column: endPositionInfo.col, + }, + }, + messageId: 'noSensitiveWord', + data: { + word, + }, + }); + }); + + // Necessary + return {}; + }, +}; diff --git a/packages/eslint-plugin-security-practices/tests/lib/rules/no-http-url.js b/packages/eslint-plugin-security-practices/tests/lib/rules/no-http-url.js new file mode 100644 index 000000000..aa53f3906 --- /dev/null +++ b/packages/eslint-plugin-security-practices/tests/lib/rules/no-http-url.js @@ -0,0 +1,32 @@ +"use strict"; + +var rule = require("../../../lib/rules/no-http-url"); +var RuleTester = require("eslint").RuleTester; + +var ruleTester = new RuleTester(); + +ruleTester.run("no-http-url", rule, { + + valid: [{ + code: "var test = 'https://test.com';" + }], + + invalid: [{ + code: "var test = 'http://test.com';", + output: "var test = 'https://test.com';", + errors: [{ + message: "Recommended 'http://test.com' switch to HTTPS" + }] + }, { + code: "