Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest] V2 addon conversion #358

Open
2 tasks done
Windvis opened this issue Jan 31, 2023 · 2 comments
Open
2 tasks done

[Quest] V2 addon conversion #358

Windvis opened this issue Jan 31, 2023 · 2 comments
Milestone

Comments

@Windvis
Copy link
Contributor

Windvis commented Jan 31, 2023

While V2 addons aren't the default yet, more and more addons are making the conversion since it speeds up app build times and brings us closer to the wider JS ecosystem.

This serves as a tracking issue to list the remaining blockers for the v2 conversion.

Blockers:

@Windvis Windvis added this to the v3 milestone Jan 31, 2023
@Windvis
Copy link
Contributor Author

Windvis commented Sep 25, 2023

Ok, I did some digging and it seems that the push based styles setup we depend on no longer works in v2 addons.

At the moment we store our .scss files in the app/styles/ember-appuniversum.scss file and subfolder. This folder gets merged with the app's app/styles folder, so they can then import it as a relative import: @import ember-appuniversum;

In v2 addons we can't push into that folder anymore, so apps would have to import from the node_modules folder instead (which requires sass configuration).

This is a breaking change so we can't do it without doing a major release.

We should probably move away from sass and use css variables instead? That way we could simply import the css files where needed and they would automatically be imported in the app as well. It would simplify the setup greatly. Apps might also need to do an import for some generic styles as well. In Embroider apps this would have the benefit that we no longer ship component styles that aren't needed, if the component isn't used.

@Windvis
Copy link
Contributor Author

Windvis commented Jan 12, 2024

WIP conversion is available in #448 but it's put on hold due to some issues with monorepo dependencies that we ran into when setting up a dedicated storybook docs app. We might need to switch to pnpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant