You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While V2 addons aren't the default yet, more and more addons are making the conversion since it speeds up app build times and brings us closer to the wider JS ecosystem.
This serves as a tracking issue to list the remaining blockers for the v2 conversion.
Ok, I did some digging and it seems that the push based styles setup we depend on no longer works in v2 addons.
At the moment we store our .scss files in the app/styles/ember-appuniversum.scss file and subfolder. This folder gets merged with the app's app/styles folder, so they can then import it as a relative import: @import ember-appuniversum;
In v2 addons we can't push into that folder anymore, so apps would have to import from the node_modules folder instead (which requires sass configuration).
This is a breaking change so we can't do it without doing a major release.
We should probably move away from sass and use css variables instead? That way we could simply import the css files where needed and they would automatically be imported in the app as well. It would simplify the setup greatly. Apps might also need to do an import for some generic styles as well. In Embroider apps this would have the benefit that we no longer ship component styles that aren't needed, if the component isn't used.
WIP conversion is available in #448 but it's put on hold due to some issues with monorepo dependencies that we ran into when setting up a dedicated storybook docs app. We might need to switch to pnpm.
While V2 addons aren't the default yet, more and more addons are making the conversion since it speeds up app build times and brings us closer to the wider JS ecosystem.
This serves as a tracking issue to list the remaining blockers for the v2 conversion.
Blockers:
The text was updated successfully, but these errors were encountered: