You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add an entry to the template-registry.ts file (if the helper isn't private), this allows glint to type check the loose-mode version
Add a test to the loose-mode-test.ts file (if the helper isn't private). This verifies that the helper/modifier is registered in the template registry.
run npm run lint:types to validate the types
Services
Choose a file that has no (untyped) dependencies
Change the extension to .ts
Add types
Convert the test file to .ts
run npm run lint:types to validate the types
The text was updated successfully, but these errors were encountered:
I think we should probably just inline the ember-data-table components here, and convert them to .gts. The way we're extending the base addon components is a bad practise anyways, and this will give us more control. It would also allow us to drop the dependency.
We should take a look at all the exposed data table components and deprecate the ones that we don't want to be used as a standalone thing. We can then remove the app-reexports in the next major.
Official support for this in Ember is starting to get better and better so it would be nice if we can support it as a first-class citizen as well.
Some options:
I think converting to .gts/.ts makes the most sense.
We might need to use this tool to strip some reference comments when publishing, since those cause issues in consuming apps.
Files we need to convert:
Components
<AuAccordion>
<AuAlert>
<AuApp>
<AuBadge>
<AuBodyContainer>
<AuBrand>
<AuButtonGroup>
<AuButton>
<AuCard>
<AuCheckboxGroup>
<AuCheckbox>
<AuContentHeader>
<AuContent>
<AuDataTable>
? This one might be tricky since it extends an addon<AuDateInput>
<AuDatePicker>
<AuDropdown>
(requires ember-focus-trap types)We have local types for that now<AuFieldset>
<AuFileCard>
<AuFileUpload>
<AuFormRow>
<AuHeading>
<AuHelpText>
<AuHr>
<AuIcon>
<AuInput>
<AuLabel>
<AuLinkExternal>
<AuLink>
<AuList>
<AuLoader>
<AuMainContainer>
<AuMainFooter>
<AuMainHeader>
<AuModalContainer>
<AuModal>
(requires ember-focus-trap types)We have local types for that now<AuNavigationLink>
<AuPanel>
<AuPill>
<AuRadioGroup>
<AuRadio>
<AuTable>
<AuTabs>
<AuTextarea>
<AuTimePicker>
<AuToaster>
<AuToggleSwitch>
<AuToolbar>
Helpers (Done)
{{link-to-models}}
(private, but we still need types internally)Modifiers (Done)
{{au-date-input}}
{{au-inputmask}}
{{floating-ui}}
(private, but we still need types internally)Services
Toaster
(Partial implementation in Toaster types #490 but it's not working fully yet)Conversion guide
Components
template-registry.ts
file, this allows glint to type check the loose-mode versionloose-mode-test.ts
file. This verifies that the component is registered in the template registry.npm run lint:types
to validate the typesHelpers & Modifiers
template-registry.ts
file (if the helper isn't private), this allows glint to type check the loose-mode versionloose-mode-test.ts
file (if the helper isn't private). This verifies that the helper/modifier is registered in the template registry.npm run lint:types
to validate the typesServices
npm run lint:types
to validate the typesThe text was updated successfully, but these errors were encountered: