Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[features] Make loader V2 default #15976

Draft
wants to merge 1 commit into
base: george/remove-feature-flag-1
Choose a base branch
from

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Feb 19, 2025

⏱️ 3h 59m total CI duration on this PR
Job Cumulative Duration Recent Runs
replay-mainnet / run-replay-verify 2h 2m 🟥
replay-testnet / run-replay-verify 1h 19m 🟥
test-target-determinator 14m 🟩🟩🟩
check-dynamic-deps 13m 🟩🟩🟩🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
general-lints 1m 🟩🟩🟩
file_change_determinator 53s 🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩
determine-test-metadata 8s 🟩
determine-docker-build-metadata 8s 🟩🟩🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@georgemitenkov georgemitenkov changed the title [features] Make loader V2 deefault [features] Make loader V2 default Feb 19, 2025
Copy link
Contributor Author

georgemitenkov commented Feb 19, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov georgemitenkov added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Feb 19, 2025
@georgemitenkov georgemitenkov force-pushed the george/remove-feature-flag-1 branch from 1c3258e to ae84e30 Compare February 19, 2025 21:03
@georgemitenkov georgemitenkov force-pushed the george/remove-feature-flag-2 branch from b963e1b to fb18eb5 Compare February 19, 2025 21:03
@georgemitenkov georgemitenkov force-pushed the george/remove-feature-flag-1 branch from ae84e30 to 7bae045 Compare February 24, 2025 12:43
@georgemitenkov georgemitenkov force-pushed the george/remove-feature-flag-2 branch from fb18eb5 to 749d343 Compare February 24, 2025 12:43
@georgemitenkov georgemitenkov mentioned this pull request Feb 24, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant