[optqs] fix len_for_execution #15988

ibalajiarun · 2025-02-20T23:15:50Z

Description

trunk-io · 2025-02-20T23:15:53Z

⏱️ 1h 55m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	55m	🟥 🟩 🟩
execution-performance / test-target-determinator	16m	🟩 🟩 🟩
test-target-determinator	10m	🟩 🟩
check-dynamic-deps	8m	🟩 🟩 🟩 🟩
rust-cargo-deny	7m	⬜ 🟩 🟩 🟩
rust-doc-tests	6m	🟩
rust-doc-tests	5m	🟩
fetch-last-released-docker-image-tag	3m	🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩
semgrep/ci	1m	🟩 🟩 🟩 🟩
file_change_determinator	46s	🟩 🟩 🟩 🟩
Backport PR	31s	🟩
file_change_determinator	24s	🟩 🟩
permission-check	11s	🟩 🟩 🟩 🟩
permission-check	11s	🟩 🟩 🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	24m	30m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

hariria · 2025-02-20T23:48:53Z

consensus/consensus-types/src/common.rs

@@ -295,7 +295,9 @@ impl Payload {
                    .sum::<usize>()) as u64)
                .min(max_txns_to_execute.unwrap_or(u64::MAX)),
            Payload::OptQuorumStore(opt_qs_payload) => {
-                opt_qs_payload.max_txns_to_execute().unwrap_or(u64::MAX)
+                let num_txns = opt_qs_payload.num_txns() as u64;


maybe safecast here...

(cherry picked from commit bb40859)

github-actions · 2025-02-22T16:06:28Z

💚 All backports created successfully

Status	Branch	Result
✅	aptos-release-v1.28

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions · 2025-02-22T16:33:48Z

✅ Forge suite `realistic_env_max_load` success on `18d572110bde9099981755bfaea9b77e99b12362`

two traffics test: inner traffic : committed: 12197.14 txn/s, submitted: 12200.93 txn/s, expired: 3.79 txn/s, latency: 3231.69 ms, (p50: 2700 ms, p70: 3000, p90: 3600 ms, p99: 11300 ms), latency samples: 4637620
two traffics test : committed: 99.98 txn/s, latency: 1950.39 ms, (p50: 1800 ms, p70: 2000, p90: 2600 ms, p99: 3700 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.760, avg: 1.494", "ConsensusProposalToOrdered: max: 0.330, avg: 0.324", "ConsensusOrderedToCommit: max: 0.632, avg: 0.586", "ConsensusProposalToCommit: max: 0.956, avg: 0.911"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.51s no progress at version 1819463 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 1816501 (avg 0.96s) [limit 16].
Test Ok

github-actions · 2025-02-22T16:33:50Z

✅ Forge suite `compat` success on `51e3afbaf4645c7a8dd03b94e47555c0dbed0366` ==> `18d572110bde9099981755bfaea9b77e99b12362`

Compatibility test results for 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362 (PR)
1. Check liveness of validators at old version: 51e3afbaf4645c7a8dd03b94e47555c0dbed0366
compatibility::simple-validator-upgrade::liveness-check : committed: 10369.07 txn/s, latency: 3052.28 ms, (p50: 2900 ms, p70: 3300, p90: 4100 ms, p99: 5800 ms), latency samples: 343600
2. Upgrading first Validator to new version: 18d572110bde9099981755bfaea9b77e99b12362
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3137.81 txn/s, latency: 9378.23 ms, (p50: 10000 ms, p70: 11400, p90: 12200 ms, p99: 12300 ms), latency samples: 69220
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3020.82 txn/s, latency: 11171.34 ms, (p50: 12200 ms, p70: 12500, p90: 13200 ms, p99: 13600 ms), latency samples: 117620
3. Upgrading rest of first batch to new version: 18d572110bde9099981755bfaea9b77e99b12362
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3063.68 txn/s, latency: 9530.09 ms, (p50: 10200 ms, p70: 11800, p90: 12500 ms, p99: 12700 ms), latency samples: 66740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3078.23 txn/s, latency: 10982.21 ms, (p50: 12100 ms, p70: 12500, p90: 12700 ms, p99: 13000 ms), latency samples: 119180
4. upgrading second batch to new version: 18d572110bde9099981755bfaea9b77e99b12362
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4908.43 txn/s, latency: 6217.26 ms, (p50: 7000 ms, p70: 7400, p90: 7900 ms, p99: 8100 ms), latency samples: 98780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2779.10 txn/s, submitted: 2779.30 txn/s, expired: 0.19 txn/s, latency: 7093.95 ms, (p50: 7700 ms, p70: 8100, p90: 8400 ms, p99: 8600 ms), latency samples: 171448
5. check swarm health
Compatibility test for 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362 passed
Test Ok

github-actions · 2025-02-22T16:34:18Z

✅ Forge suite `framework_upgrade` success on `51e3afbaf4645c7a8dd03b94e47555c0dbed0366` ==> `18d572110bde9099981755bfaea9b77e99b12362`

Compatibility test results for 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362 (PR)
Upgrade the nodes to version: 18d572110bde9099981755bfaea9b77e99b12362
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1871.91 txn/s, submitted: 1879.28 txn/s, failed submission: 7.36 txn/s, expired: 7.36 txn/s, latency: 1566.66 ms, (p50: 1500 ms, p70: 1800, p90: 2300 ms, p99: 3100 ms), latency samples: 162700
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1606.72 txn/s, submitted: 1612.22 txn/s, failed submission: 5.50 txn/s, expired: 5.50 txn/s, latency: 1795.50 ms, (p50: 1500 ms, p70: 1900, p90: 3000 ms, p99: 4000 ms), latency samples: 146040
5. check swarm health
Compatibility test for 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362 passed
Upgrade the remaining nodes to version: 18d572110bde9099981755bfaea9b77e99b12362
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1035.43 txn/s, submitted: 1037.01 txn/s, failed submission: 1.59 txn/s, expired: 1.59 txn/s, latency: 2963.16 ms, (p50: 1800 ms, p70: 2200, p90: 11400 ms, p99: 13600 ms), latency samples: 91362
Test Ok

ibalajiarun requested review from zekun000 and sasha8 as code owners February 20, 2025 23:15

[optqs] fix len_for_execution

18d5721

ibalajiarun force-pushed the balaji/optqs branch from 0c3ff6b to 18d5721 Compare February 20, 2025 23:17

zekun000 approved these changes Feb 20, 2025

View reviewed changes

ibalajiarun enabled auto-merge (squash) February 20, 2025 23:20

This comment has been minimized.

Sign in to view

hariria approved these changes Feb 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

ibalajiarun merged commit bb40859 into main Feb 21, 2025
86 of 89 checks passed

ibalajiarun deleted the balaji/optqs branch February 21, 2025 00:18

ibalajiarun added the v1.28 label Feb 22, 2025

github-actions bot pushed a commit that referenced this pull request Feb 22, 2025

[optqs] fix len_for_execution (#15988)

0c238ef

(cherry picked from commit bb40859)

github-actions bot mentioned this pull request Feb 22, 2025

[cp][aptos-release-v1.28] [optqs] fix len_for_execution #16001

Closed

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[optqs] fix len_for_execution #15988

[optqs] fix len_for_execution #15988

ibalajiarun commented Feb 20, 2025

trunk-io bot commented Feb 20, 2025 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hariria Feb 20, 2025

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2025

github-actions bot commented Feb 22, 2025

github-actions bot commented Feb 22, 2025

[optqs] fix len_for_execution #15988

[optqs] fix len_for_execution #15988

Conversation

ibalajiarun commented Feb 20, 2025

Description

trunk-io bot commented Feb 20, 2025 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hariria Feb 20, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2025

💚 All backports created successfully

Questions ?

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2025

✅ Forge suite realistic_env_max_load success on 18d572110bde9099981755bfaea9b77e99b12362

github-actions bot commented Feb 22, 2025

✅ Forge suite compat success on 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362

github-actions bot commented Feb 22, 2025

✅ Forge suite framework_upgrade success on 51e3afbaf4645c7a8dd03b94e47555c0dbed0366 ==> 18d572110bde9099981755bfaea9b77e99b12362

trunk-io bot commented Feb 20, 2025 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `18d572110bde9099981755bfaea9b77e99b12362`

✅ Forge suite `compat` success on `51e3afbaf4645c7a8dd03b94e47555c0dbed0366` ==> `18d572110bde9099981755bfaea9b77e99b12362`

✅ Forge suite `framework_upgrade` success on `51e3afbaf4645c7a8dd03b94e47555c0dbed0366` ==> `18d572110bde9099981755bfaea9b77e99b12362`