Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aqua g -i removes new lines #584

Closed
suzuki-shunsuke opened this issue Feb 24, 2022 · 1 comment
Closed

aqua g -i removes new lines #584

suzuki-shunsuke opened this issue Feb 24, 2022 · 1 comment
Labels
Milestone

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Feb 24, 2022

aqua version

Please use the latest version.

$ aqua -v
aqua version 1.1.0-1 (29095a314be902a216d0eec145cd0e3c0dc08e1f)

aqua g's -i option was addded from v1.1.0-0

Environment

⚠️ aqua doesn't support Windows.

  • OS (Linux, macOS, etc): macOS, Linux
  • CPU Architecture (amd64, arm64, etc): arm64, amd64

I guess OS and Architecture aren't related.

Overview

aqua g -i removes new lines.

How to reproduce

  • aqua.yaml
  • executed command and output

aqua.yaml should be not partial but complete configuration.
Please remove unneeded configuration to reproduce the issue.

aqua.yaml

---
# aqua - Declarative CLI Version Manager
# https://aquaproj.github.io/
registries:
- type: standard
  ref: v1.4.0 # renovate: depName=aquaproj/aqua-registry

packages:
$ aqua g -i cli/cli

Debug Output

Please set the environment variable AQUA_LOG_LEVEL=debug and run aqua and tell us the debug output.

$ 

Expected Behaviour

New lines are kept.

---
# aqua - Declarative CLI Version Manager
# https://aquaproj.github.io/
registries:
- type: standard
  ref: v1.4.0 # renovate: depName=aquaproj/aqua-registry

packages:
- name: cli/cli@v2.5.1

Actual Behaviour

New lines are removed.

---
# aqua - Declarative CLI Version Manager
# https://aquaproj.github.io/
registries:
- type: standard
  ref: v1.4.0 # renovate: depName=aquaproj/aqua-registry
packages:
- name: cli/cli@v2.5.1

Important Factoids

goccy/go-yaml is used as YAML Parser.

Workaround

Add empty comments # instead of new lines

e.g.

---
# aqua - Declarative CLI Version Manager
# https://aquaproj.github.io/
registries:
- type: standard
  ref: v1.4.0 # renovate: depName=aquaproj/aqua-registry
#
packages:

References

@suzuki-shunsuke
Copy link
Member Author

The issue would be solved at the next release.

@suzuki-shunsuke suzuki-shunsuke added this to the v2.37.1 milestone Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant