Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue introduced in commit ee6a4f5 (related to #343) #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicolargo
Copy link

Remove the " typo.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@AkselAllas
Copy link

@simar7

@AkselAllas
Copy link

This repo's standards need to be increased. This PR should have failed via an automated test.

Tons of action's users just wasted time on this mistake.

@@ -195,7 +195,7 @@ if [ "${format}" == "sarif" ] && [ "${limitSeveritiesForSARIF}" != "true" ]; the
trivy --quiet ${scanType} --format sarif --output ${output} $SARIF_ARGS ${artifactRef}
elif [ $trivyConfig ]; then
echo "Running Trivy with trivy.yaml config from: " $trivyConfig
trivy --config $trivyConfig ${scanType} ${ARGS}" ${artifactRef}
trivy --config $trivyConfig ${scanType} ${ARGS} ${artifactRef}
Copy link

@aitrics-ray aitrics-ray Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, it'd be nice to meet conventions.

Suggested change
trivy --config $trivyConfig ${scanType} ${ARGS} ${artifactRef}
echo "Running Trivy with trivy.yaml config from: ${trivyConfig}"
trivy --config "${trivyConfig}" "${scanType}" "${ARGS}" "${artifactRef}"

FYI
https://google.github.io/styleguide/shellguide.html#s5.6-variable-expansion

Copy link

@AkselAllas AkselAllas Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "${trivyConfig}" "${scanType}" "${ARGS}" "${artifactRef}" unless ARGS really needs to be unquoted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@StemadsenCardlay
Copy link

@nicolargo I think you need to sign the CLA

@nicolargo
Copy link
Author

@nicolargo I think you need to sign the CLA

I do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants