Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about the limitation in Rekor #3494

Merged

Conversation

developer-guy
Copy link
Contributor

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Description

This PR aims to add information about the limitation in Rekor about the attestation size.

Related issues

  • Close #XXX

Related PRs

sigstore/rekor#1313
aquasecurity/trivy-plugin-attest#6

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. leaving for @knqyf263 for merging
If you want to make the warning more prominent, feel free to replace > with !!! note https://squidfunk.github.io/mkdocs-material/reference/admonitions/
we use this annotation extensively also in this file

@afdesk afdesk changed the title add note about the limitation in Rekor docs: add note about the limitation in Rekor Jan 31, 2023
@knqyf263 knqyf263 merged commit 023e45b into aquasecurity:main Feb 1, 2023
@knqyf263
Copy link
Collaborator

knqyf263 commented Feb 1, 2023

Thanks👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants