-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dart): use first version of constraint for dependencies using SDK version #6239
Merged
knqyf263
merged 11 commits into
aquasecurity:main
from
DmitriyLewen:feat-dart/sdk-versions-for-deps
Jun 5, 2024
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
835cc07
feat(dart): use first version of constraint for dependencies using SD…
DmitriyLewen 6f861aa
docs: add info about sdk deps
DmitriyLewen e8a892a
fix linter error
DmitriyLewen c5ce4bc
fix: use sdk version for ID
DmitriyLewen f585220
Merge branch 'main' into 'feat-dart/sdk-versions-for-deps'
DmitriyLewen 1aa02bb
Merge branch 'main' into 'feat-dart/sdk-versions-for-deps'
DmitriyLewen eb67467
refactor: use go-version to detect sdk version
DmitriyLewen 0bbe7c5
fix linter error
DmitriyLewen 91c2b1b
chore(deps): bump github.com/aquasecurity/go-version
DmitriyLewen 35a6f0a
feat: add length checks for `css.List()`
DmitriyLewen 191270c
refactor: separate a method
knqyf263 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,4 +22,4 @@ packages: | |
version: "3.0.6" | ||
sdks: | ||
dart: ">=2.18.0 <3.0.0" | ||
flutter: ">=3.3.0" | ||
flutter: "^3.3.0" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to parse the constraints in a more stable way. What if we export
constraint
and add methods likefunc (c *Constraint) Version() string
andfunc (c *Constraint) Operator() string
in go-version?https://github.com/aquasecurity/go-version/blob/637058cfe4921e395b56f195224538d7eac61520/pkg/version/constraint.go#L55-L59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Created aquasecurity/go-version#6
And updated this PR - 0bbe7c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
aquasecurity/go-version#6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this PR -91c2b1b