Tests/deposit lib #303
Merged
Tests/deposit lib #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Giorgi-Lagidze seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
nivida
suggested changes
Mar 16, 2021
| // Below two events are duplicated from the DepositLib library to make sure that this contract | ||
| // contains the Locked/Unlocked event in its own abi in order to test if the events were thrown or not. | ||
| // For more info: https://github.com/ethereum/solidity/pull/10996 | ||
| event Locked(address indexed token, address indexed from, uint256 amount); |
There was a problem hiding this comment.
Not correctly intended (line 15-18)
| const amount = 1000 | ||
|
|
||
| describe('DepositLib', function () { | ||
| let depositLibMock: DepositLibMock |
There was a problem hiding this comment.
This can be done with one let keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.