From 42435bd9a656860a9d37f39a724e89776e2e52b8 Mon Sep 17 00:00:00 2001 From: jordaniza Date: Fri, 15 Mar 2024 17:39:27 +0400 Subject: [PATCH 1/2] docs: add a checklist item to PR template && fix broken link --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 354416052..82266ba3c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,6 @@ ## Description -Please include a summary of the change and be sure you follow the contributions rules we do provide [here](./CONTRIBUTIONS.md) +Please include a summary of the change and be sure you follow the contributions rules we do provide [here](../CONTRIBUTIONS.md) Task ID: [OS-?](https://aragonassociation.atlassian.net/browse/OS-?) @@ -25,3 +25,4 @@ See the framework lifecylce in `packages/contracts/docs/framework-lifecycle` to - [ ] I have updated the `CHANGELOG.md` file in the root folder. - [ ] I have updated the `DEPLOYMENT_CHECKLIST` file in the root folder. - [ ] I have updated the `UPDATE_CHECKLIST` file in the root folder. +- [ ] I have updated the Subgraph and added a QA URL to the description of this PR. From da250d385884c2fbd5de3e34bb19f5dbd53668d6 Mon Sep 17 00:00:00 2001 From: jordaniza Date: Mon, 25 Mar 2024 16:30:42 +0000 Subject: [PATCH 2/2] chore: updated CONTRIBUTION GUIDE --- CONTRIBUTION_GUIDE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTION_GUIDE.md b/CONTRIBUTION_GUIDE.md index 1ca436379..a3e54075c 100644 --- a/CONTRIBUTION_GUIDE.md +++ b/CONTRIBUTION_GUIDE.md @@ -78,8 +78,11 @@ If the answer to either of those two questions are "yes", then you're probably d [ ] My changes generate no new warnings. [ ] Any dependent changes have been merged and published in downstream modules. [ ] I ran all tests with success and extended them if necessary. - [ ] I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version. [ ] I have tested my code on the test network. + [ ] I have updated the `CHANGELOG.md` file in the root folder. + [ ] I have updated the `DEPLOYMENT_CHECKLIST` file in the root folder. + [ ] I have updated the `UPDATE_CHECKLIST` file in the root folder. + [ ] I have updated the Subgraph and added a QA URL to the description of this PR. ``` 6. Wait for the pull request to be reviewed by the team.