Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram Model References show up as archimate-diagram-model #95

Open
jcrum opened this issue Aug 11, 2021 · 4 comments
Open

Diagram Model References show up as archimate-diagram-model #95

jcrum opened this issue Aug 11, 2021 · 4 comments

Comments

@jcrum
Copy link

jcrum commented Aug 11, 2021

Version of jArchi, Operating System

Archi Version: 4.8.1 (tested on 4.7.# as well)
jArchi Version: 1.10.202101121529
MacOS: 10.15

Expected Behavior

I'm making an assumption as to how this behave since the documentation around this area is a bit fuzzy but....

If a view contains References to other views/diagrams (i.e. dragging a view/diagram from the navigation tree onto a view) it should show up as type: diagram-model-reference.

Actual Behavior

Diagram Reference Objects show up as type: archimate-diagram-model.
script_output

Steps to Reproduce the Behaviour (with attached test files/script)

  1. Create several views/diagrams in a model
  2. Drag said views/diagrams from the navigation tree onto a view
  3. Execute a script that displays the view/diagram children and type

archimate-diagram-model-defect.archimate.zip

diagram_ref_bug.ajs.zip

@Phillipus
Copy link
Member

The underlying implementation of getType() returns the underlying referenced object or concept. So object.type on a diagram element or connection will return the concept (business-actor, for example) and the same is true for a view reference, it returns the referenced view.

Perhaps we should make this clearer in the wiki.

@jcrum
Copy link
Author

jcrum commented Aug 17, 2021

Is there any way to get the type for these elements rather than their referenced type?

@Phillipus
Copy link
Member

Is there any way to get the type for these elements rather than their referenced type?

I'll re-open this issue for discussion...

This would need some fundamental changes to return actual type rather than referenced type.

@Phillipus Phillipus reopened this Aug 17, 2021
@jcrum
Copy link
Author

jcrum commented Aug 17, 2021

Thank you for reopening although I'm not sure how much important this is if it hasn't been brought up before. I'll see if there is another way to get my script to work.

Phillipus added a commit that referenced this issue Aug 2, 2024
…e of the DiagramModelReference object

- It should return "diagram-model-reference" not the type of the referenced diagram model

- This aligns it with "diagram-model-note", "diagram-model-group" and "diagram-model-connection"

- But see #95
Phillipus added a commit that referenced this issue Aug 9, 2024
…e of the DiagramModelReference object

- It should return "diagram-model-reference" not the type of the referenced diagram model

- This aligns it with "diagram-model-note", "diagram-model-group" and "diagram-model-connection"

- But see #95
Phillipus added a commit that referenced this issue Oct 10, 2024
…e of the DiagramModelReference object

- It should return "diagram-model-reference" not the type of the referenced diagram model

- This aligns it with "diagram-model-note", "diagram-model-group" and "diagram-model-connection"

- But see #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants