diff --git a/changelog.md b/changelog.md index 2fe9b8ad..a61085b8 100644 --- a/changelog.md +++ b/changelog.md @@ -31,6 +31,8 @@ - Breaking change: the `deploy.dirty` API method is now fully deprecated, please use `deploy.direct` instead - Internal change: moved most internal CloudFormation mutations into Package (where they rightly belong), via the `deployStage` param - Upgraded CloudFront HTTPS TLS protocol to `TLSv1.2_2021` +- Migrate static bucket permissions from per-object ACLs to a bucket policy so users can customize the static bucket permissions using macros + - See: https://github.com/architect/package/pull/148, https://github.com/architect/deploy/pull/350 - Stop publishing to the GitHub Package registry --- diff --git a/src/static/publish/s3/put-files/put-params.js b/src/static/publish/s3/put-files/put-params.js index e365dd1f..1d64b62e 100644 --- a/src/static/publish/s3/put-files/put-params.js +++ b/src/static/publish/s3/put-files/put-params.js @@ -6,7 +6,6 @@ let getContentType = require('./get-content-type') module.exports = function putParams (params) { let { Bucket, Key, Body, file, fingerprint } = params let s3Params = { - ACL: 'public-read', Bucket, Key, Body, diff --git a/test/unit/static/publish/s3/put-files/put-params-test.js b/test/unit/static/publish/s3/put-files/put-params-test.js index a52d2629..5d7f0f5f 100644 --- a/test/unit/static/publish/s3/put-files/put-params-test.js +++ b/test/unit/static/publish/s3/put-files/put-params-test.js @@ -10,7 +10,7 @@ test('Module is present', t => { }) test('S3 put params', t => { - t.plan(9) + t.plan(8) let html = 'public/index.html' let json = 'public/something.json' @@ -27,7 +27,6 @@ test('S3 put params', t => { // Basic params let result = sut(params) - t.equal(result.ACL, 'public-read', 'File is set to public-read ACL') t.equal(result.Bucket, Bucket, 'Bucket is unchanged') t.equal(result.Key, 'index.html', 'Key is unchanged') t.equal(result.ContentType, 'text/html', 'Content type properly set')