Skip to content

Conversation

@fiseni
Copy link
Collaborator

@fiseni fiseni commented Jan 13, 2022

Some of the ORM features are not available in EF Core 3, so we've been using preprocessor directives. The condition was fine, but now that we added additional TFM net6.0, they're excluded from it as well.

	public SpecificationEvaluator(bool cacheEnabled = false)
	{
		this.evaluators.AddRange(new IEvaluator[]
		{
			WhereEvaluator.Instance,
			SearchEvaluator.Instance,
			cacheEnabled ? IncludeEvaluator.Cached : IncludeEvaluator.Default,
			OrderEvaluator.Instance,
			PaginationEvaluator.Instance,
			AsNoTrackingEvaluator.Instance,
			IgnoreQueryFiltersEvaluator.Instance,
#if NETSTANDARD2_1
			AsSplitQueryEvaluator.Instance,
			AsNoTrackingWithIdentityResolutionEvaluator.Instance
#endif
		});
	}

So, instead of #if NETSTANDARD2_1, we should use negation #if !NETSTANDARD2_0.

@fiseni fiseni requested a review from ardalis January 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants