opt: rem redundant deserialize method

Author: eigen-value

src/decoder.h

@@ -56,7 +56,7 @@ class RpcDecoder {
     template<typename RType>
     bool get_response(const int msg_id, RType& result, RpcError& error) {
 
-        if (!packet_incoming() || packet_type()!=RESP_MSG) return false;
+        if (packet_type()!=RESP_MSG) return false;
 
         MsgPack::Unpacker unpacker;
 

src/rpclite_utils.h

@@ -134,11 +134,6 @@ deserialize_tuple(MsgPack::Unpacker& unpacker, std::tuple<Ts...>& out) {
     return deserialize_tuple<I + 1>(unpacker, out);
 }
 
-template<typename... Ts>
-inline bool deserialize_all(MsgPack::Unpacker& unpacker, std::tuple<Ts...>& values) {
-    return deserialize_tuple(unpacker, values);
-}
-
 // Helper to invoke a function with a tuple of arguments
 template<typename F, typename Tuple, std::size_t... I>
 inline auto invoke_with_tuple(F&& f, Tuple&& t, arx::stdx::index_sequence<I...>)

src/wrapper.h

@@ -80,7 +80,7 @@ class RpcFunctionWrapper<std::function<R(Args...)>>: public IFunctionWrapper {
     handle_call(MsgPack::Unpacker& unpacker, MsgPack::Packer& packer) {
         //unpacker not ready if deserialization fails at this point
         std::tuple<Args...> args;
-        if (!deserialize_all<Args...>(unpacker, args)) return false;
+        if (!deserialize_tuple(unpacker, args)) return false;
         MsgPack::object::nil_t nil;
         invoke_with_tuple(_func, args, arx::stdx::make_index_sequence<sizeof...(Args)>{});
         packer.serialize(nil, nil);
@@ -92,7 +92,7 @@ class RpcFunctionWrapper<std::function<R(Args...)>>: public IFunctionWrapper {
     handle_call(MsgPack::Unpacker& unpacker, MsgPack::Packer& packer) {
         //unpacker not ready if deserialization fails at this point
         std::tuple<Args...> args;
-        if (!deserialize_all<Args...>(unpacker, args)) return false;
+        if (!deserialize_tuple(unpacker, args)) return false;
         MsgPack::object::nil_t nil;
         R out = invoke_with_tuple(_func, args, arx::stdx::make_index_sequence<sizeof...(Args)>{});
         packer.serialize(nil, out);