feat: DecoderManager.size # of active decoders. RPCServer.get_rpc as bool. warn: Stream constructors create multiple decoders on the same transport

Author: eigen-value

src/client.h

@@ -14,6 +14,7 @@ class RPCClient {
 
     RPCClient(ITransport& t) : decoder(&RpcDecoderManager<>::getDecoder(t)) {}
 
+    // TODO This is problematic becasue 'new' makes different Transport objs and different transports make different decoders
     RPCClient(Stream& stream) {
         ITransport* transport = (ITransport*) new SerialTransport(stream);
         decoder = &RpcDecoderManager<>::getDecoder(*transport);

src/decoder_manager.h

@@ -23,6 +23,7 @@ class RpcDecoderManager {
                 entry.transport = &transport;
                 // In-place construct
                 entry.decoder = new (&entry.decoder_storage.instance) RpcDecoder<>(transport);
+                decoders_size++;
                 return *entry.decoder;
             }
         }
@@ -31,6 +32,10 @@ class RpcDecoderManager {
         while (true);
     }
 
+    static size_t size() {
+        return decoders_size;
+    }
+
 private:
     struct DecoderStorage {
         union {
@@ -49,10 +54,14 @@ class RpcDecoderManager {
     };
 
     static std::array<Entry, MaxTransports> decoders_;
+    static size_t decoders_size;
 };
 
 // Definition of the static member
 template<size_t MaxTransports>
 std::array<typename RpcDecoderManager<MaxTransports>::Entry, MaxTransports> RpcDecoderManager<MaxTransports>::decoders_;
 
+template<size_t MaxTransports>
+size_t RpcDecoderManager<MaxTransports>::decoders_size = 0;
+
 #endif //RPCLITE_DECODER_MANAGER_H

src/server.h

@@ -16,6 +16,7 @@ class RPCServer {
 public:
     RPCServer(ITransport& t) : decoder(&RpcDecoderManager<>::getDecoder(t)) {}
 
+    // TODO This is problematic becasue 'new' makes different Transport objs and different transports make different decoders
     RPCServer(Stream& stream) {
         ITransport* transport = (ITransport*) new SerialTransport(stream);
         decoder = &RpcDecoderManager<>::getDecoder(*transport);
@@ -34,10 +35,11 @@ class RPCServer {
     }
 
 protected:
-    void get_rpc() {
+    bool get_rpc() {
         decoder->decode();
-        if (_rpc_size > 0) return; // Already have a request
+        if (_rpc_size > 0) return true; // Already have a request
         _rpc_size = decoder->get_request(_rpc_buffer, RPC_BUFFER_SIZE);
+        return _rpc_size > 0;
     }
 
     void process_request() {