-
Notifications
You must be signed in to change notification settings - Fork 9
[bricks] model configuration - refactoring for list of variables #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dido18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split the PR.
- PR#1. [NO-ISSUE] Remove the
model_configuration_variablesfrom thebrick-config.yaml. The arduino-app-cli does not read/use it. - PR#2. [BREAKING] Move the
model_configurationunder themodel-list.yamland put the configuration variable for each brick. This is a breaking change. - PR#X [Enhancement] When needed, open PR to add the boolean field into the
brick_config.yaml. Each addition should be discussed and clearly described
private: true => the variable is only used internally (i.e., the model path)
mandatory: true => if the variable must be filled
secret: true => a variable that is a secret.
I do not agree. |
| - "${CUSTOM_MODEL_PATH:-/home/arduino/.arduino-bricks/ei-models/}:${CUSTOM_MODEL_PATH:-/home/arduino/.arduino-bricks/ei-models/}" | ||
| - "/run/udev:/run/udev" | ||
| command: ["--model-file", "${EI_CLASSIFICATION_MODEL:-/models/ootb/ei/mobilenet-v2-224px.eim}", "--dont-print-predictions", "--mode", "streaming", "--preview-original-resolution", "--camera", "${VIDEO_DEVICE:-/dev/video1}"] | ||
| command: ["--model-file", "${EI_V_CLASSIFICATION_MODEL:-/models/ootb/ei/mobilenet-v2-224px.eim}", "--dont-print-predictions", "--mode", "streaming", "--preview-original-resolution", "--camera", "${VIDEO_DEVICE:-/dev/video1}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the diff between EI_CLASSIFICATION_MODEL and EI_V_CLASSIFICATION_MODEL variable?
Is the name of the variable changed on purpose?
| command: ["--model-file", "${EI_V_CLASSIFICATION_MODEL:-/models/ootb/ei/mobilenet-v2-224px.eim}", "--dont-print-predictions", "--mode", "streaming", "--preview-original-resolution", "--camera", "${VIDEO_DEVICE:-/dev/video1}"] | |
| command: ["--model-file", "${EI_CLASSIFICATION_MODEL:-/models/ootb/ei/mobilenet-v2-224px.eim}", "--dont-print-predictions", "--mode", "streaming", "--preview-original-resolution", "--camera", "${VIDEO_DEVICE:-/dev/video1}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EI_CLASSIFICATION_MODEL was already used by object detection brick. Changed to fix the overlap.
| - name: EI_AUDIO_CLASSIFICATION_MODEL | ||
| description: Path to the model file | ||
| private: true | ||
| - name: CUSTOM_MODEL_PATH | ||
| description: Path to the custom model directory | ||
| private: true | ||
| - name: BIND_ADDRESS | ||
| description: Bind address | ||
| private: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly think we could just remove those variables. I would avoid to add the private concepts if it isn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not agree. Thsi are useful and the concept of private is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? Why are they useful? Those are set by the model, so I am not sure why they should be defined here.
Allow to specify a per brick configuration in model's list file.
Migrate compose files variable definition inside bricks config to allow to specify more metadata