Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project Go version for generating website content #167

Merged
merged 1 commit into from
May 15, 2023
Merged

Use project Go version for generating website content #167

merged 1 commit into from
May 15, 2023

Commits on May 12, 2023

  1. Use project Go version for generating website content

    The project documentation is published on a companion website. A GitHub Actions workflow is used to automatically update
    the website whenever any relevant file is changed in the repository. This website includes content generated from the
    project's Go code.
    
    Previously, the default version of Go from the GitHub Actions runner machine was used for generating the documentation
    content. A recent update of this default Go version from 1.17 to 1.20 caused the generation process to fail:
    
    ```
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x83c1a6]
    
    goroutine 1 [running]:
    debug/elf.(*Section).ReadAt(0xc0001be000?, {0xc0001ce000?, 0x24?, 0x23?}, 0x23?)
    	<autogenerated>:1 +0x26
    archive/zip.readDirectoryEnd({0xa37480, 0xc0000af580}, 0x210)
    	/opt/hostedtoolcache/go/1.20.3/x64/src/archive/zip/reader.go:581 +0xf5
    archive/zip.(*Reader).init(0xc000137500, {0xa37480?, 0xc0000af580}, 0x210)
    	/opt/hostedtoolcache/go/1.20.3/x64/src/archive/zip/reader.go:124 +0x5c
    archive/zip.NewReader({0xa37480, 0xc0000af580}, 0x210)
    	/opt/hostedtoolcache/go/1.20.3/x64/src/archive/zip/reader.go:103 +0x5e
    github.com/daaku/go%2ezipexe.zipExeReaderElf({0xa38040?, 0xc0000140f0}, 0xdc51bf)
    	/home/runner/go/pkg/mod/github.com/daaku/go.zipexe@v1.0.0/zipexe.go:128 +0x8b
    github.com/daaku/go%2ezipexe.NewReader({0xa38040, 0xc0000140f0}, 0x0?)
    	/home/runner/go/pkg/mod/github.com/daaku/go.zipexe@v1.0.0/zipexe.go:48 +0x98
    github.com/daaku/go%2ezipexe.OpenCloser({0xc0000822a0?, 0xc0000e5720?})
    	/home/runner/go/pkg/mod/github.com/daaku/go.zipexe@v1.0.0/zipexe.go:30 +0x57
    github.com/cmaglie/go%2erice.init.0()
    	/home/runner/go/pkg/mod/github.com/cmaglie/go.rice@v1.0.3/appended.go:42 +0x65
    task: Failed to run task "go:cli-docs": exit status 2
    ```
    
    This error, and the general fragility that comes from not controlling the Go version, is avoided by configuring the
    workflow to use the specific version of Go that is used for development and validation of the project.
    per1234 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b5e0961 View commit details
    Browse the repository at this point in the history