Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Manager includes all files in repository instead of just those tagged in my GitHub release? #116

Closed
HomeSpan opened this issue Dec 4, 2020 · 3 comments
Assignees
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@HomeSpan
Copy link

HomeSpan commented Dec 4, 2020

My HomeSpan library was just included in the Arduino Library Manager - thank you. However, the library manager appears to be downloading all files in the repository, not just the files that are part of source.zip when I created the specific GitHub tag. Am I labeling something incorrectly? I want to make sure that only the files that have been bundled in the tagged release are downloaded by the library manager.

@per1234
Copy link
Contributor

per1234 commented Dec 4, 2020

I'll add a bit more information to make sure the situation is clear to the person investigating this issue:

I see that you have given some paths in your repository the export-ignore attribute:
https://github.com/HomeSpan/HomeSpan/blob/1.0.1/.gitattributes

Meaning the archive will have a folder structure like:

├── examples
├── library.properties
├── LICENSE
├── Other Examples
└── src

But the archive provided by the Library Manager index contains the "ignored" paths, resulting in a structure like:

├── docs
├── documents
├── examples
├── library.properties
├── LICENSE
├── Other Examples
└── src

@HomeSpan
Copy link
Author

HomeSpan commented Dec 4, 2020

Yes, that's exactly the problem. Thanks.

@per1234
Copy link
Contributor

per1234 commented Dec 8, 2020

I discovered a previous issue about this: #59
It's best for us to have only one open issue for each topic in order to consolidate all the information in a single place, so I'm going to close this one in favor of the original. You can subscribe to that issue to get updates of any progress.

@per1234 per1234 closed this as completed Dec 8, 2020
@per1234 per1234 transferred this issue from arduino/Arduino Apr 7, 2022
@per1234 per1234 added conclusion: duplicate Has already been submitted type: enhancement Proposed improvement topic: code Related to content of the project itself and removed Type: Duplicate labels Apr 7, 2022
@per1234 per1234 self-assigned this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants