Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup v0.5.0 releasenote formatting #201

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

yardasol
Copy link
Contributor

Summary of changes

This PR cleans up the formatting of v0.5.0 release notes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • My change is a user-facing change
    • I have recorded my changes in the changelog for the upcoming release
  • My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
    • I have verified or justified that my change will work as intended.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol yardasol requested a review from LukeSeifert February 26, 2024 15:39
Copy link
Contributor

@LukeSeifert LukeSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some nitpicks: Punctuation is inconsistent between different bullet points, line 110 chaged to changed, inconsistent verb usage (add/added/adds are all used), and calculate_removal_efficiency doesn't have parentheses (not sure if this is an attribute or a method). @ me when you're ready for me to merge

@yardasol yardasol requested a review from LukeSeifert February 26, 2024 18:59
@LukeSeifert LukeSeifert merged commit e47ef8d into arfc:master Feb 26, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
…eleasenotes

Cleanup v0.5.0 releasenote formatting e47ef8d
github-actions bot pushed a commit to khurrumsaleem/saltproc that referenced this pull request Feb 28, 2024
….0-releasenotes

Cleanup v0.5.0 releasenote formatting e47ef8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants