Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add additional resources to an Application #10258

Closed
gigi206 opened this issue Aug 9, 2022 · 5 comments
Closed

Allow to add additional resources to an Application #10258

gigi206 opened this issue Aug 9, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@gigi206
Copy link

gigi206 commented Aug 9, 2022

Summary

Add the possibility to add custom resources yaml to an Application.

Motivation

Some charts don't allow to add custom yaml values. In some cases, it could be great to add custom code to the original chart.

Proposal

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: myapp
  namespace: argo-cd
spec:
  project: default
  source:
    repoURL: 'https://github.com/xxx/yyy/'
    path: client/config/crd
    targetRevision: v4.2.1
  destination:
    server: 'https://kubernetes.default.svc'
    namespace: myns
  syncPolicy:
    syncOptions:
      - PruneLast=true
  additionalResources:
    # valueFiles: []
    values: |
      apiVersion: v1
      kind: Service
      metadata:
        name: my-service
      spec:
        selector:
          app: MyApp
        ports:
          - protocol: TCP
            port: 80
            targetPort: 9376
@gigi206 gigi206 added the enhancement New feature or request label Aug 9, 2022
@crenshaw-dev crenshaw-dev changed the title Allow to add additionnal ressources to an Application Allow to add additional resources to an Application Aug 9, 2022
@crenshaw-dev
Copy link
Member

Would a multi-source application fit your use case? #8322

@gigi206
Copy link
Author

gigi206 commented Aug 9, 2022

Yes it could :)

I see that I must wait until the 2.5 release ;)

@crenshaw-dev
Copy link
Member

Yep! An umbrella chart (pulling in your Helm chart as a dependency of a new, top-level chart) is probably the way to go until then.

@wmgroot
Copy link
Contributor

wmgroot commented Aug 30, 2022

PR is here for those following.
#10432

@blakepettersson
Copy link
Member

Closing since this feature has been out for a while: https://argo-cd.readthedocs.io/en/stable/user-guide/multiple_sources/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants