Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of CMPv2 plugin.name for 2.5 and in the future #11751

Closed
thedatabaseme opened this issue Dec 19, 2022 · 2 comments
Closed

Status of CMPv2 plugin.name for 2.5 and in the future #11751

thedatabaseme opened this issue Dec 19, 2022 · 2 comments
Labels
component:cmp Config Management Plugin related issues enhancement New feature or request

Comments

@thedatabaseme
Copy link
Contributor

Summary

I've read the issue #11290 and the according PR #11341 which reimplemented plugin.name also for CMPv2 in future versions.
I've understood, that this should be implemented in Argo 2.6, which brings up three questions or proposals to me.

  1. Will plugin.name still be specifyable when CMPv1 is removed (planned in Argo 2.7)?
  2. The documentation has not been updated to my knowledge, regardless in which version of Argo doc. Or was it?
  3. Backport the PR to all Argo versions that support CMPv2. At least Argo 2.5, because this version is now somewhere "inbetween".

Motivation

Having a clear way of implementing CMPv2 in all supporting versions.

Proposal

Backport PR #11341 to Argo 2.5 and update the documentation accordingly. Keep support of specifying plugin.name regardless of the CMP version used for all supported Argo versions.

@thedatabaseme thedatabaseme added the enhancement New feature or request label Dec 19, 2022
@crenshaw-dev
Copy link
Member

crenshaw-dev commented Dec 19, 2022

  1. Yep!
  2. PRs fix: remove argocd-cm plugin warnings #11740 and docs: update config management plugin docs #11690 should cover it I think.
  3. I'm not opposed to a backport. It would avoid people having to do 2.5->2.6->2.7 when they'd rather go 2.5->2.7.

@alexmt wdyt?

@crenshaw-dev crenshaw-dev added the component:cmp Config Management Plugin related issues label Dec 19, 2022
@jsoref
Copy link
Member

jsoref commented Jan 23, 2023

@crenshaw-dev: can you please add spaces after the PR numbers in #11751 (comment)

@jgwest jgwest closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cmp Config Management Plugin related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants