Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add myself to reviewers #8802

Merged
merged 1 commit into from
Mar 16, 2022
Merged

chore: Add myself to reviewers #8802

merged 1 commit into from
Mar 16, 2022

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Mar 16, 2022 •
edited
Loading

Excited to be part of the ArgoCD team! Thanks @alexmt @jessesuen @jannfis for sponsoring!

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@terrytangyuan
chore: Add myself to reviewers
6b58f8b 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
jannfis
jannfis approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎉

@wanghong230
Copy link
Member

Congratulations!

alexmt
alexmt approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!

@alexmt alexmt merged commit 2888a9d into argoproj:master Mar 16, 2022
@terrytangyuan terrytangyuan deleted the add-terry branch March 16, 2022 21:07
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
@terrytangyuan @wojtekidd
chore: Add myself to reviewers (argoproj#8802)
350b626 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@wanghong230 wanghong230 wanghong230 approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrytangyuan @wanghong230 @alexmt @jannfis