From 72d0d22e6254c2871f7f4f3798a362094409064f Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Wed, 31 Jul 2024 23:10:44 -0400 Subject: [PATCH] fix(ui): import `getTemplateNameFromNode` Fixes #13415 (https://github.com/argoproj/argo-workflows/issues/13415) - 27a283ac5db1651ecb6f59c9f693bd9be1ab6fac ended up getting cherry-picked/backported before b1c51df6365fa7900ceb13da87ed54bffaf1704d, causing the import to disappear and crashing the UI when `getTemplateNameFromNode` was attempted to be used - one removed the import and the other added it; the removal ended up being an "invisible" merge conflict - and the `release-3.5` build apparently doesn't type-check, so it didn't get caught in CI. see the issue for more details on that. Signed-off-by: Anton Gilgur --- .../components/workflow-logs-viewer/workflow-logs-viewer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx b/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx index 1f42e68f34b3..07f8ef0fc903 100644 --- a/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx +++ b/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx @@ -12,7 +12,7 @@ import {InfoIcon, WarningIcon} from '../../../shared/components/fa-icons'; import {Links} from '../../../shared/components/links'; import {Context} from '../../../shared/context'; import {useLocalStorage} from '../../../shared/hooks/uselocalstorage'; -import {getPodName} from '../../../shared/pod-name'; +import {getPodName, getTemplateNameFromNode} from '../../../shared/pod-name'; import {ScopedLocalStorage} from '../../../shared/scoped-local-storage'; import {services} from '../../../shared/services'; import {FullHeightLogsViewer} from './full-height-logs-viewer';