use headless service for kafka in minikube #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinandj
approved these changes
Oct 9, 2017
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
* Support fetching/checkouts of non-branch/-tag git refs Provides a `source.git.ref` field for specifying a specific non-branch non-tag git ref at which to perform a checkout. Providing one will result in a shallow (depth 1) clone of the repo and shallow subsequent fetches. The motivation for this change is to support sourcing of trigger templates from Gerrit patchsets. Gerrit uses non-branch/-tag refs extensively and specifically in this case stores change patchsets in `refs/changes/[slice]/[change]/[patchset]`. While arbitrary refs are kind of an obscure git feature, there very well may be other git based systems utilizing them. * Fixed protobuf field index for Ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #321