Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add containerized make commands. Resolves #6519 #6618

Closed
wants to merge 11 commits into from

Conversation

JPZ13
Copy link
Member

@JPZ13 JPZ13 commented Aug 27, 2021

This PR:

  • Adds containerized versions of make commands that are commonly run while developing

It works by spinning up a container that holds tooling dependencies and volume mounting it on the user's filesystem.
The goal is to allow for development without having to spend as much time configuring your host machine.

JPZ13 added 6 commits August 27, 2021 12:11
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #6618 (caf62ca) into master (d19909a) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6618      +/-   ##
==========================================
+ Coverage   48.52%   48.60%   +0.08%     
==========================================
  Files         261      262       +1     
  Lines       18955    18975      +20     
==========================================
+ Hits         9197     9222      +25     
+ Misses       8738     8721      -17     
- Partials     1020     1032      +12     
Impacted Files Coverage Δ
workflow/sync/chain_throttler.go 68.75% <0.00%> (-31.25%) ⬇️
workflow/sync/throttler.go 93.20% <0.00%> (-3.39%) ⬇️
pkg/apiclient/apiclient.go 7.69% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 71.28% <0.00%> (-0.44%) ⬇️
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/watch-intermediary.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-workflow-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
.../http1/cluster-workflow-template-service-client.go 0.00% <0.00%> (ø)
...o-kube-cluster-workflow-template-service-client.go 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19909a...caf62ca. Read the comment docs.

JPZ13 added 3 commits August 28, 2021 22:30
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this out on a Mac M1 and got qemu: uncaught target signal 11 (Segmentation fault) - core dumped.

@JPZ13
Copy link
Member Author

JPZ13 commented Sep 4, 2021

Just tried this out on a Mac M1 and got qemu: uncaught target signal 11 (Segmentation fault) - core dumped.

It seems docker bind mounts are pretty spotty on M1 Macs. @terrytangyuan, have you used docker-sync on your M1? I'm on an Intel based Mac and can't reproduce. I'll port it over to docker sync if it's a smooth M1 experience

Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@terrytangyuan
Copy link
Member

I tried docker-sync once but I remember it was stuck somewhere waiting for the sync forever so I gave up.

@JPZ13
Copy link
Member Author

JPZ13 commented Sep 26, 2021

Running into the docker-sync problems @terrytangyuan mentioned above. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants