-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add containerized make commands. Resolves #6519 #6618
Conversation
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6618 +/- ##
==========================================
+ Coverage 48.52% 48.60% +0.08%
==========================================
Files 261 262 +1
Lines 18955 18975 +20
==========================================
+ Hits 9197 9222 +25
+ Misses 8738 8721 -17
- Partials 1020 1032 +12
Continue to review full report at Codecov.
|
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried this out on a Mac M1 and got qemu: uncaught target signal 11 (Segmentation fault) - core dumped
.
It seems docker bind mounts are pretty spotty on M1 Macs. @terrytangyuan, have you used docker-sync on your M1? I'm on an Intel based Mac and can't reproduce. I'll port it over to docker sync if it's a smooth M1 experience |
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
I tried docker-sync once but I remember it was stuck somewhere waiting for the sync forever so I gave up. |
Running into the docker-sync problems @terrytangyuan mentioned above. Closing for now |
This PR:
It works by spinning up a container that holds tooling dependencies and volume mounting it on the user's filesystem.
The goal is to allow for development without having to spend as much time configuring your host machine.