Disallow repeated headers.

chriseth · chriseth · commit f647ec1588f7 · 2021-12-16T16:39:07.000+01:00
diff --git a/libsolidity/lsp/Transport.cpp b/libsolidity/lsp/Transport.cpp
@@ -131,7 +131,11 @@ optional<map<string, string>> IOStreamTransport::parseHeaders()
 
 		string name = boost::to_lower_copy(line.substr(0, delimiterPos));
 		string value = line.substr(delimiterPos + 1);
-		headers[boost::trim_copy(name)] = boost::trim_copy(value);
+		if (!headers.emplace(
+			boost::trim_copy(name),
+			boost::trim_copy(value)
+		).second)
+			return nullopt;
 	}
 	return {move(headers)};
 }

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,11 @@ optional<map<string, string>> IOStreamTransport::parseHeaders()`
`131`	`131`
`132`	`132`	`string name = boost::to_lower_copy(line.substr(0, delimiterPos));`
`133`	`133`	`string value = line.substr(delimiterPos + 1);`
`134`		`- headers[boost::trim_copy(name)] = boost::trim_copy(value);`
	`134`	`+ if (!headers.emplace(`
	`135`	`+ boost::trim_copy(name),`
	`136`	`+ boost::trim_copy(value)`
	`137`	`+ ).second)`
	`138`	`+ return nullopt;`
`135`	`139`	`}`
`136`	`140`	`return {move(headers)};`
`137`	`141`	`}`