Skip to content

[test] Add support for --enforce-compile-to-ewasm. #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chriseth merged 1 commit into from
Apr 27, 2021
Merged

[test] Add support for --enforce-compile-to-ewasm. #10356

chriseth merged 1 commit into from
Apr 27, 2021

Conversation

@aarlt
Copy link
Collaborator

@aarlt aarlt commented Nov 19, 2020

No description provided.

@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from 293492f to ec1be4d Compare November 19, 2020 21:47
@aarlt aarlt marked this pull request as draft November 20, 2020 04:38
@aarlt aarlt force-pushed the ewasm-polyfill-calldataload-calldatacopy branch 2 times, most recently from 7ac8b50 to 4d7565b Compare November 20, 2020 04:45
@axic axic force-pushed the ewasm-polyfill-calldataload-calldatacopy branch from 4d7565b to b542cfa Compare November 20, 2020 13:31
@aarlt aarlt force-pushed the ewasm-polyfill-calldataload-calldatacopy branch 3 times, most recently from 0291afd to 9d6296e Compare November 20, 2020 19:17
Base automatically changed from ewasm-polyfill-calldataload-calldatacopy to develop November 20, 2020 21:12
@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from ec1be4d to d1c9c4b Compare November 21, 2020 13:23
chriseth
chriseth reviewed Nov 23, 2020
View reviewed changes
@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch 2 times, most recently from e42df92 to 1226e0b Compare November 23, 2020 19:38
@aarlt aarlt marked this pull request as ready for review November 24, 2020 02:12
@aarlt aarlt requested a review from chriseth November 26, 2020 22:57
leonardoalt
leonardoalt reviewed Nov 30, 2020
View reviewed changes
leonardoalt
leonardoalt reviewed Nov 30, 2020
View reviewed changes
leonardoalt
leonardoalt reviewed Nov 30, 2020
View reviewed changes
leonardoalt
leonardoalt reviewed Nov 30, 2020
View reviewed changes
leonardoalt
leonardoalt reviewed Nov 30, 2020
View reviewed changes
@aarlt aarlt mentioned this pull request Nov 30, 2020
Closed
@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from 1226e0b to 652e255 Compare November 30, 2020 22:49
@aarlt aarlt requested a review from leonardoalt December 1, 2020 01:12
leonardoalt
leonardoalt reviewed Dec 4, 2020
View reviewed changes
@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from 652e255 to 8a45df2 Compare December 18, 2020 02:40
leonardoalt
leonardoalt reviewed Jan 12, 2021
View reviewed changes
@leonardoalt
Copy link

leonardoalt commented Jan 19, 2021

ping @aarlt , also please rebase

@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from 8a45df2 to f83673b Compare January 20, 2021 03:04
leonardoalt
leonardoalt reviewed Jan 22, 2021
View reviewed changes
@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from f83673b to f7f436f Compare January 23, 2021 22:05
@cameel cameel mentioned this pull request Jan 28, 2021
Merged
3 tasks
@leonardoalt
Copy link

leonardoalt commented Mar 4, 2021

Reviewer comments not implemented

@leonardoalt
Copy link

leonardoalt commented Mar 26, 2021

Ping @aarlt

@axic axic mentioned this pull request Apr 23, 2021
Merged
@axic
Copy link
Contributor

axic commented Apr 23, 2021

Rebased.

@axic axic force-pushed the isoltest-add-enforce-ewasm branch 3 times, most recently from 9d35179 to c247380 Compare April 23, 2021 15:46
@axic
Copy link
Contributor

axic commented Apr 23, 2021

@cameel since you had the most change requests, could you take this over once the more important PRs are merged?

@axic
Copy link
Contributor

axic commented Apr 23, 2021

Ran this with: test/tools/isoltest --enforce-compile-to-ewasm --evm-version byzantium --ewasm -t semanticTests/* --accept-updates

@axic axic mentioned this pull request Apr 23, 2021
Merged
@cameel
Copy link
Collaborator

cameel commented Apr 23, 2021

@axic OK. I'm reviewing a different PR right now but I can take this over when I'm done.

@axic axic force-pushed the isoltest-add-enforce-ewasm branch from 86c66da to 5937f16 Compare April 23, 2021 19:28
cameel
cameel reviewed Apr 23, 2021
View reviewed changes
cameel
cameel reviewed Apr 23, 2021
View reviewed changes
cameel
cameel reviewed Apr 23, 2021
View reviewed changes
cameel
cameel reviewed Apr 23, 2021
View reviewed changes
cameel
cameel previously requested changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Looks like not all of the old comments have been addresses and there are also a few minor problems.

BTW, thanks for renaming the variables. They're much easier to understand now. It would be better if they were renamed in a separate commit or PR because that adds quite a bit of noise here but still, it's much better than leaving them as they were :)

@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch 3 times, most recently from d02bb9d to cdf2f00 Compare April 26, 2021 17:25
cameel
cameel reviewed Apr 26, 2021
View reviewed changes
@cameel
Copy link
Collaborator

cameel commented Apr 26, 2021

I have posted some minor tweaks above but other than that I think the PR is fine now.

What about the parts you said on the chat are gone after the rebase?

@cameel cameel dismissed their stale review April 26, 2021 19:07

The PR still needs minor tweaks but no longer has any significant issues

@aarlt aarlt force-pushed the isoltest-add-enforce-ewasm branch from cdf2f00 to da38149 Compare April 27, 2021 01:31
@aarlt
Copy link
Collaborator Author

aarlt commented Apr 27, 2021

What about the parts you said on the chat are gone after the rebase?

Thats solved now. I accidentally removed the initialisation of the isoltest-builtins. But now it's back.

@chriseth chriseth merged commit 3548049 into develop Apr 27, 2021
@chriseth chriseth deleted the isoltest-add-enforce-ewasm branch April 27, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameel cameel cameel approved these changes

@chriseth chriseth Awaiting requested review from chriseth

+2 more reviewers

@axic axic axic left review comments

@leonardoalt leonardoalt leonardoalt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aarlt @leonardoalt @axic @cameel @chriseth