[isoltest] Add support to query balance. #10873

aarlt · 2021-02-01T19:53:27Z

Depends on #10867
Fixes #10426.

test/libsolidity/SemanticTest.cpp

test/libsolidity/semanticTests/builtins/balance_other_contract.sol

roru78 · 2021-02-15T13:18:30Z

Нет описания.

isoltest-balance

leonardoalt · 2021-03-26T13:26:04Z

Needs rebase

leonardoalt · 2021-04-22T08:39:40Z

I rebased this, hope I didn't screw anything up, there was a one line conflict in SemanticTest.h.
Other than that I think it's good to go?

chriseth · 2021-04-22T14:04:18Z

Something is not right.

aarlt · 2021-04-23T05:07:05Z

test/libsolidity/util/TestFileParser.cpp

 							tie(call.signature, lowLevelCall) = parseFunctionSignature();
 							if (lowLevelCall)
 								call.kind = FunctionCall::Kind::LowLevel;
+							if (isBuiltinFunction(call.signature))


@mijovic Looks like that you accidentally removed these lines. Strange that we did not have any isoltest builtin function tests in place. We should merge this PR soon.

Hm, I am not sure how I did that... Does it makes sense to extract this out and add as separate PR to merge these back?

Yes, makes sense. Just created #11304.

test/libsolidity/semanticTests/builtins/balance_other_contract.sol

axic · 2021-04-26T20:25:49Z

test/libsolidity/semanticTests/builtins/balance_other_contract.sol

@@ -0,0 +1,29 @@
+contract Other {


I'd rename this directory to isoltestTesting or something else, but builtins here suggests precompiles or some solidity builtins.

chriseth · 2021-04-27T15:04:12Z

test/libsolidity/SemanticTest.cpp

 		return util::toBigEndian(u256(0x1234));
 	};
+	soltestAssert(m_builtins.count("accountBalance") == 0, "");
+	m_builtins["accountBalance"] = [this](FunctionCall const& _call) -> std::optional<bytes>


Can we only use a single builtin called balance which has an optional parameter that defaults to the contract address?

Yes, thats possible.

axic · 2021-04-28T14:02:14Z

test/libsolidity/semanticTests/isoltestTesting/balance_without_balance.sol

+// compileViaYul: also
+// ----
+// balance -> 0
+// balance: 0x0000000000000000000000000000000000000000 -> 0


Does the wei/ether suffix works on the returned value?

axic · 2021-04-28T14:02:46Z

test/libsolidity/semanticTests/smoke/constructor.sol

 // ----
 // constructor(), 2 wei: 3 ->
 // state() -> 3
-// balance() -> 2


Should remove the balance() function from this contract.

I'll use both.

axic · 2021-04-28T14:02:55Z

test/libsolidity/semanticTests/smoke/fallback.sol

 // (): hex"42ef"
 // data() -> 2
 // externalData() -> 0x20, 2, left(0x42ef)
-// balance() -> 0


~~Should remove the balance function in this contract.~~

This contract seems to have balance() as a public variable. Are we sure this change here is correct?

I'll revert.

Ah, it seems you cannot call a function called balance anymore.

chriseth

The builtin mechanism has to be changed, it still has to be possible to call all functions. Builtins and user-defined functions can be distinguished by ().

chriseth · 2021-04-28T14:17:10Z

The above is implemented in #11326 Rebasing on top of that.

aarlt force-pushed the isoltest-builtins branch from c180cc3 to 7903410 Compare February 1, 2021 20:04

aarlt force-pushed the isoltest-balance branch from 7def49c to 2b55e88 Compare February 1, 2021 20:08

aarlt marked this pull request as draft February 1, 2021 20:20

chriseth reviewed Feb 2, 2021

View reviewed changes

test/libsolidity/SemanticTest.cpp Outdated Show resolved Hide resolved

chriseth reviewed Feb 2, 2021

View reviewed changes

test/libsolidity/SemanticTest.cpp Outdated Show resolved Hide resolved

chriseth reviewed Feb 2, 2021

View reviewed changes

test/libsolidity/semanticTests/builtins/balance_other_contract.sol Outdated Show resolved Hide resolved

aarlt force-pushed the isoltest-builtins branch 4 times, most recently from 18a3cfe to d4dc5c3 Compare February 15, 2021 11:58

aarlt force-pushed the isoltest-builtins branch 11 times, most recently from afc5e06 to df5ae1a Compare February 16, 2021 18:34

aarlt force-pushed the isoltest-balance branch from 2b55e88 to 026bc82 Compare February 16, 2021 19:48

aarlt force-pushed the isoltest-builtins branch from df5ae1a to 3dbdea9 Compare February 16, 2021 19:49

aarlt force-pushed the isoltest-balance branch 3 times, most recently from a8430c5 to 30a3eeb Compare February 16, 2021 20:16

aarlt marked this pull request as ready for review February 16, 2021 20:28

aarlt force-pushed the isoltest-builtins branch 2 times, most recently from 22d9e9b to 71d1a9e Compare February 17, 2021 16:36

leonardoalt force-pushed the isoltest-balance branch from b5bc8dc to 66ef23b Compare April 22, 2021 08:39

aarlt force-pushed the isoltest-balance branch from 66ef23b to 991fb6c Compare April 23, 2021 05:03

aarlt commented Apr 23, 2021

View reviewed changes

test/libsolidity/semanticTests/builtins/balance_other_contract.sol Show resolved Hide resolved

aarlt force-pushed the isoltest-balance branch 2 times, most recently from bb58b29 to f8d8802 Compare April 26, 2021 18:46

axic reviewed Apr 26, 2021

View reviewed changes

chriseth reviewed Apr 27, 2021

View reviewed changes

aarlt force-pushed the isoltest-balance branch 2 times, most recently from 0e97f53 to 1c674ab Compare April 27, 2021 22:45

chriseth force-pushed the isoltest-balance branch from 1c674ab to 5c90b12 Compare April 28, 2021 13:56

chriseth approved these changes Apr 28, 2021

View reviewed changes

chriseth enabled auto-merge April 28, 2021 13:57

axic reviewed Apr 28, 2021

View reviewed changes

axic mentioned this pull request Apr 28, 2021

[isoltest] Add balance: statement #10426

Closed

axic reviewed Apr 28, 2021

View reviewed changes

chriseth disabled auto-merge April 28, 2021 14:05

chriseth suggested changes Apr 28, 2021

View reviewed changes

[isoltest] Add support to query balance.

19ad9fa

chriseth force-pushed the isoltest-balance branch from 5c90b12 to 19ad9fa Compare April 28, 2021 14:19

chriseth changed the base branch from develop to builtin_user_function April 28, 2021 14:19

chriseth approved these changes Apr 28, 2021

View reviewed changes

Base automatically changed from builtin_user_function to develop April 28, 2021 14:56

chriseth merged commit 850c25b into develop Apr 28, 2021

chriseth deleted the isoltest-balance branch April 28, 2021 15:01

[isoltest] Add support to query balance. #10873

[isoltest] Add support to query balance. #10873

Uh oh!

Conversation

aarlt commented Feb 1, 2021 • edited by axic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roru78 commented Feb 15, 2021

Uh oh!

leonardoalt commented Mar 26, 2021

Uh oh!

leonardoalt commented Apr 22, 2021

Uh oh!

chriseth commented Apr 22, 2021

Uh oh!

aarlt Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chriseth Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

axic Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chriseth left a comment

Choose a reason for hiding this comment

Uh oh!

chriseth commented Apr 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aarlt commented Feb 1, 2021 •

edited by axic

Loading

aarlt Apr 23, 2021 •

edited

Loading

chriseth Apr 27, 2021 •

edited

Loading

axic Apr 28, 2021 •

edited

Loading